Merge pull request rails#51299 from ElvinEfendi/support-custom-blob-key-in-compose

Support custom blob key in ActiveStorage::Blob#compose similar to other Blob APIs

Author: rafaelfranca

activestorage/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Add support for custom `key` in `ActiveStorage::Blob#compose`.
+
+    *Elvin Efendiev*
+
 *   Add `image/webp` to `config.active_storage.web_image_content_types` when `load_defaults "7.2"`
     is set.
 

activestorage/app/models/active_storage/blob.rb

@@ -142,12 +142,12 @@ def scope_for_strict_loading # :nodoc:
     end
 
     # Concatenate multiple blobs into a single "composed" blob.
-    def compose(blobs, filename:, content_type: nil, metadata: nil)
+    def compose(blobs, key: nil, filename:, content_type: nil, metadata: nil)
       raise ActiveRecord::RecordNotSaved, "All blobs must be persisted." if blobs.any?(&:new_record?)
 
       content_type ||= blobs.pluck(:content_type).compact.first
 
-      new(filename: filename, content_type: content_type, metadata: metadata, byte_size: blobs.sum(&:byte_size)).tap do |combined_blob|
+      new(key: key, filename: filename, content_type: content_type, metadata: metadata, byte_size: blobs.sum(&:byte_size)).tap do |combined_blob|
         combined_blob.compose(blobs.pluck(:key))
         combined_blob.save!
       end

activestorage/test/models/blob_test.rb

@@ -135,6 +135,14 @@ class ActiveStorage::BlobTest < ActiveSupport::TestCase
     assert_equal "All blobs must be persisted.", error.message
   end
 
+  test "compose with custom key" do
+    blobs = 3.times.map { create_blob(data: "123", filename: "numbers.txt", content_type: "text/plain", identify: false) }
+    blob = ActiveStorage::Blob.compose(blobs, key: "custom_key", filename: "all_numbers.txt")
+
+    assert_equal "custom_key", blob.key
+    assert_equal "123123123", blob.download
+  end
+
   test "image?" do
     blob = create_file_blob filename: "racecar.jpg"
     assert_predicate blob, :image?