use Karma as the test runner for the UJS tests

Author: lsylvester

Gemfile

@@ -112,7 +112,6 @@ end
 
 # Action View
 group :view do
-  gem "blade", require: false, platforms: [:ruby]
   gem "sprockets-export", require: false
 end
 

Gemfile.lock

@@ -140,19 +140,6 @@ GEM
     beaneater (1.1.1)
     benchmark-ips (2.9.2)
     bindex (0.8.1)
-    blade (0.7.3)
-      activesupport (>= 3.0.0)
-      blade-qunit_adapter (>= 2.0.1)
-      coffee-script
-      coffee-script-source
-      curses (>= 1.4.0)
-      eventmachine
-      faye
-      sprockets (>= 3.0)
-      thin (>= 1.6.0)
-      thor (>= 0.19.1)
-      useragent (>= 0.16.7)
-    blade-qunit_adapter (2.0.1)
     bootsnap (1.9.3)
       msgpack (~> 1.0)
     builder (3.2.4)
@@ -170,20 +157,13 @@ GEM
       xpath (~> 3.2)
     cgi (0.3.6)
     childprocess (4.1.0)
-    coffee-script (2.4.1)
-      coffee-script-source
-      execjs
-    coffee-script-source (1.12.2)
     concurrent-ruby (1.1.9)
     connection_pool (2.2.5)
-    cookiejar (0.3.3)
     crack (0.4.5)
       rexml
     crass (1.0.6)
     cssbundling-rails (1.1.0)
       railties (>= 6.0.0)
-    curses (1.4.4)
-    daemons (1.4.1)
     dalli (3.2.0)
     dante (0.2.0)
     debug (1.4.0)
@@ -211,7 +191,6 @@ GEM
     et-orbi (1.2.6)
       tzinfo
     event_emitter (0.2.6)
-    eventmachine (1.2.7)
     execjs (2.8.1)
     faraday (1.8.0)
       faraday-em_http (~> 1.0)
@@ -234,17 +213,6 @@ GEM
     faraday-rack (1.0.0)
     faraday_middleware (1.2.0)
       faraday (~> 1.0)
-    faye (1.4.0)
-      cookiejar (>= 0.3.0)
-      em-http-request (>= 1.1.6)
-      eventmachine (>= 0.12.0)
-      faye-websocket (>= 0.11.0)
-      multi_json (>= 1.0.0)
-      rack (>= 1.0.0)
-      websocket-driver (>= 0.5.1)
-    faye-websocket (0.11.1)
-      eventmachine (>= 0.12.0)
-      websocket-driver (>= 0.5.1)
     ffi (1.15.4)
     fugit (1.5.2)
       et-orbi (~> 1.1, >= 1.1.8)
@@ -286,7 +254,6 @@ GEM
       os (>= 0.9, < 2.0)
       signet (>= 0.16, < 2.a)
     hashdiff (1.0.1)
-    http_parser.rb (0.8.0)
     httpclient (2.8.3)
     i18n (1.8.11)
       concurrent-ruby (~> 1.0)
@@ -518,10 +485,6 @@ GEM
       railties (>= 6.0.0)
     terser (1.1.8)
       execjs (>= 0.3.0, < 3)
-    thin (1.8.1)
-      daemons (~> 1.0, >= 1.0.9)
-      eventmachine (~> 1.0, >= 1.0.4)
-      rack (>= 1, < 3)
     thor (1.2.1)
     tilt (2.0.10)
     timeout (0.3.1)
@@ -575,7 +538,6 @@ DEPENDENCIES
   backburner
   bcrypt (~> 3.1.11)
   benchmark-ips
-  blade
   bootsnap (>= 1.4.4)
   capybara (>= 3.26)
   cgi (>= 0.3.6)

actionview/.gitignore

@@ -1,4 +1,5 @@
 /lib/assets/compiled/
+/test/ujs/compiled/
 /log/
 /test/fixtures/public/absolute/
 /test/ujs/log/

actionview/RUNNING_UJS_TESTS.rdoc

@@ -1,8 +1,9 @@
 == Running UJS tests
 
-Ensure that you can build the project by running:
-   rake ujs:server
+Run the tests in headless mode by running:
+
+   rake test:ujs
 
-Then run the web tests by visiting the following URL in your browser:
+To run the tests in a browser, start the Rails UJS server by running:
 
-   http://localhost:4567
+   rake ujs:server

actionview/Rakefile

@@ -3,6 +3,7 @@
 require "rake/testtask"
 require "fileutils"
 require "open3"
+require "base64"
 
 desc "Default Task"
 task default: :test
@@ -38,15 +39,6 @@ namespace :test do
       listen_host = "localhost"
       listen_port = "4567"
 
-      runner_command = %w(ruby ../ci/qunit-selenium-runner.rb)
-      if ENV["SELENIUM_DRIVER_URL"]
-        require "socket"
-        runner_command += %W(http://#{Socket.gethostname}:#{listen_port}/ #{ENV["SELENIUM_DRIVER_URL"]})
-        listen_host = "0.0.0.0"
-      else
-        runner_command += %W(http://localhost:#{listen_port}/)
-      end
-
       Dir.mkdir("log")
       pid = File.open("log/test.log", "w") do |f|
         spawn(*%W(rackup test/ujs/config.ru -o #{listen_host} -p #{listen_port} -s puma), out: f, err: f, pgroup: true)
@@ -66,8 +58,7 @@ namespace :test do
 
         sleep 0.2
       end
-
-      system(*runner_command)
+      system(Hash[*Base64.decode64(ENV.fetch("ENCODED", "")).split(/[ =]/)], "npm", "test")
       status = $?.exitstatus
     ensure
       Process.kill("KILL", -pid) if pid
@@ -101,7 +92,8 @@ end
 namespace :ujs do
   desc "Starts the test server"
   task :server do
-    system "bundle exec rackup test/ujs/config.ru -p 4567 -s puma"
+    spawn("bundle exec rackup test/ujs/config.ru -p 4567 -s puma")
+    system("npm test -- --no-single-run --browsers Chrome")
   end
 end
 

actionview/karma.conf.js

@@ -0,0 +1,64 @@
+const config = {
+  browsers: ["ChromeHeadless"],
+  frameworks: ["qunit"],
+  files: [
+    "test/ujs/compiled/test.js",
+  ],
+
+  client: {
+    clearContext: false,
+    qunit: {
+      showUI: true
+    }
+  },
+
+  singleRun: true,
+  autoWatch: false,
+
+  captureTimeout: 180000,
+  browserDisconnectTimeout: 180000,
+  browserDisconnectTolerance: 3,
+  browserNoActivityTimeout: 300000,
+  proxies: {
+    '/echo': 'http://localhost:4567/echo',
+    '/error': 'http://localhost:4567/error'
+  }
+}
+
+if (process.env.CI) {
+  config.customLaunchers = {
+    sl_chrome: sauce("chrome", "latest", "Windows 10")
+  }
+
+  config.browsers = Object.keys(config.customLaunchers)
+  config.reporters = ["dots", "saucelabs"]
+
+  config.sauceLabs = {
+    testName: "Rails UJS",
+    retryLimit: 3,
+    build: buildId(),
+  }
+
+  function sauce(browserName, version, platform) {
+    const options = {
+      base: "SauceLabs",
+      browserName: browserName.toString(),
+      version: version.toString(),
+    }
+    if (platform) {
+      options.platform = platform.toString()
+    }
+    return options
+  }
+
+  function buildId() {
+    const { BUILDKITE_JOB_ID } = process.env
+    return BUILDKITE_JOB_ID
+      ? `Buildkite ${BUILDKITE_JOB_ID}`
+      : ""
+  }
+}
+
+module.exports = function(karmaConfig) {
+  karmaConfig.set(config)
+}

actionview/package.json

@@ -12,7 +12,8 @@
   },
   "scripts": {
     "build": "rollup --config rollup.config.js",
-    "test": "echo \"See the README: https://github.com/rails/rails/blob/main/actionview/app/assets/javascripts#how-to-run-tests\" && exit 1",
+    "pretest": "rollup --config rollup.config.test.js",
+    "test": "karma start",
     "lint": "eslint app/javascript"
   },
   "repository": {
@@ -31,8 +32,16 @@
   },
   "homepage": "https://rubyonrails.org/",
   "devDependencies": {
+    "@rollup/plugin-commonjs": "^19.0.1",
+    "@rollup/plugin-node-resolve": "^11.0.1",
     "eslint": "^4.19.1",
     "eslint-plugin-import": "^2.23.4",
+    "jquery": "^2.2.0",
+    "karma": "^3.1.1",
+    "karma-chrome-launcher": "^2.2.0",
+    "karma-qunit": "^2.1.0",
+    "karma-sauce-launcher": "^1.2.0",
+    "qunit": "^2.8.0",
     "rollup": "^2.53.3",
     "rollup-plugin-terser": "^7.0.2"
   }

actionview/rollup.config.test.js

@@ -0,0 +1,16 @@
+import commonjs from "@rollup/plugin-commonjs"
+import resolve from "@rollup/plugin-node-resolve"
+
+export default {
+  input: "test/ujs/src/test.js",
+
+  output: {
+    file: "test/ujs/compiled/test.js",
+    format: "iife"
+  },
+
+  plugins: [
+    resolve(),
+    commonjs()
+  ]
+}

actionview/test/ujs/public/test/attach-bindings.js

@@ -0,0 +1,8 @@
+document.addEventListener('rails:attachBindings', function() {
+  window.Rails.linkClickSelector += ', a[data-custom-remote-link]';
+  // Hijacks link click before ujs binds any handlers
+  // This is only used for ctrl-clicking test on remote links
+  window.Rails.delegate(document, '#qunit-fixture a', 'click', function(e) {
+    e.preventDefault();
+  });
+});

actionview/test/ujs/public/test/call-ajax.js

@@ -1,4 +1,5 @@
-(function() {
+import $ from 'jquery'
+import Rails from "../../../../app/javascript/rails-ujs/index"
 
 QUnit.module('call-ajax', {
   beforeEach: function() {
@@ -24,5 +25,3 @@ QUnit.test('call ajax without "ajax:beforeSend"', function(assert) {
 
   link.triggerNative('click')
 })
-
-})()