Only serialize associations that were loaded

Fix: rails#51807

`association_cached?` only means the Association object was
created, not that the records were loaded.

Co-Authored-By: benk-gc <[email protected]>

Author: byroot

activerecord/lib/active_record/marshalling.rb

@@ -25,7 +25,7 @@ def _marshal_dump_7_1
         payload = [attributes_for_database, new_record?]
 
         cached_associations = self.class.reflect_on_all_associations.select do |reflection|
-          association_cached?(reflection.name)
+          association_cached?(reflection.name) && association(reflection.name).loaded?
         end
 
         unless cached_associations.empty?

activerecord/lib/active_record/message_pack.rb

@@ -80,7 +80,7 @@ def build_entry(record)
 
       def add_cached_associations(record, entry)
         record.class.normalized_reflections.each_value do |reflection|
-          if record.association_cached?(reflection.name)
+          if record.association_cached?(reflection.name) && record.association(reflection.name).loaded?
             entry << reflection.name << encode(record.association(reflection.name).target)
           end
         end

activerecord/test/cases/marshal_serialization_test.rb

@@ -78,6 +78,10 @@ def test_rails_7_1_rountrip
       assert_same topic, reply.topic
     end
 
+    topic.association(:open_replies)
+    assert_equal true, topic.association_cached?(:open_replies)
+    assert_not_predicate topic.association(:open_replies), :loaded?
+
     topic = Marshal.load(Marshal.dump(topic))
 
     assert_not_predicate topic, :new_record?
@@ -86,6 +90,8 @@ def test_rails_7_1_rountrip
     assert_equal "Have a nice day", topic.content
     assert_predicate topic.association(:replies), :loaded?
 
+    assert_not_predicate topic.association(:open_replies), :loaded?
+
     assert_not_equal 0, topic.replies.size
     topic.replies.each do |reply|
       assert_same topic, reply.topic