Merge pull request rails#52321 from rails/fxn/rm-ActiveRecord-ImmutableRelation

Delete the deprecated constant ActiveRecord::ImmutableRelation

Author: fxn

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Delete the deprecated constant `ActiveRecord::ImmutableRelation`.
+
+    *Xavier Noria*
+
 *   Fix duplicate callback execution when child autosaves parent with `has_one` and `belongs_to`.
 
     Before, persisting a new child record with a new associated parent record would run `before_validation`,

activerecord/lib/active_record/errors.rb

@@ -484,11 +484,6 @@ def initialize(model = nil, description = nil)
   #   relation.limit!(5)              # => ActiveRecord::UnmodifiableRelation
   class UnmodifiableRelation < ActiveRecordError
   end
-  deprecate_constant(
-    :ImmutableRelation,
-    "ActiveRecord::UnmodifiableRelation",
-    deprecator: ActiveRecord.deprecator
-  )
 
   # TransactionIsolationError will be raised under the following conditions:
   #

activerecord/test/cases/errors_test.rb

@@ -16,11 +16,4 @@ def test_can_be_instantiated_with_no_args
       end
     end
   end
-
-  def test_active_record_immutable_relation_deprecation
-    expected_message = "ActiveRecord::ImmutableRelation is deprecated! Use ActiveRecord::UnmodifiableRelation instead"
-    assert_deprecated(expected_message, ActiveRecord.deprecator) do
-      assert_same ActiveRecord::UnmodifiableRelation, ActiveRecord::ImmutableRelation
-    end
-  end
 end