Merge pull request rails#46632 from nickh/nh-set-fk-on-association-create

Add set_new_record to singular create associations

Author: eileencodes

activerecord/lib/active_record/associations/singular_association.rb

@@ -57,6 +57,7 @@ def _create_record(attributes, raise_error = false, &block)
           reflection.klass.transaction do
             record = build(attributes, &block)
             saved = record.save
+            set_new_record(record)
             raise RecordInvalid.new(record) if !saved && raise_error
             record
           end

activerecord/test/cases/associations/belongs_to_associations_test.rb

@@ -1443,6 +1443,15 @@ def test_should_set_foreign_key_on_create_association!
     assert_equal firm.id, client.client_of
   end
 
+  def test_should_set_foreign_key_on_create_association_with_unpersisted_owner
+    tagging = Tagging.new
+    tag = tagging.create_tag
+
+    assert_not_predicate tagging, :persisted?
+    assert_predicate tag, :persisted?
+    assert_equal tag.id, tagging.tag_id
+  end
+
   def test_should_set_foreign_key_on_save
     client = Client.create! name: "fuu"
     firm   = client.build_firm name: "baa"