Remove deprecated ActiveRecord::Base.arel_attribute

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated `ActiveRecord::Base.arel_attribute`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `ActiveRecord::Base.connection_config`.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/core.rb

@@ -421,11 +421,6 @@ def arel_table # :nodoc:
         @arel_table ||= Arel::Table.new(table_name, klass: self)
       end
 
-      def arel_attribute(name, table = arel_table) # :nodoc:
-        table[name]
-      end
-      deprecate :arel_attribute
-
       def predicate_builder # :nodoc:
         @predicate_builder ||= PredicateBuilder.new(table_metadata)
       end

activerecord/lib/active_record/relation.rb

@@ -41,11 +41,6 @@ def initialize_copy(other)
       reset
     end
 
-    def arel_attribute(name) # :nodoc:
-      table[name]
-    end
-    deprecate :arel_attribute
-
     def bind_attribute(name, value) # :nodoc:
       if reflection = klass._reflect_on_association(name)
         name = reflection.foreign_key

activerecord/test/cases/base_test.rb

@@ -95,18 +95,6 @@ def test_arel_attribute_normalization
     assert_equal Post.arel_table["body"], Post.arel_table[:text]
   end
 
-  def test_deprecated_arel_attribute
-    assert_deprecated do
-      assert_equal Post.arel_table["body"], Post.arel_attribute(:body)
-    end
-  end
-
-  def test_deprecated_arel_attribute_on_relation
-    assert_deprecated do
-      assert_equal Post.arel_table["body"], Post.all.arel_attribute(:body)
-    end
-  end
-
   def test_incomplete_schema_loading
     topic = Topic.first
     payload = { foo: 42 }

guides/source/7_0_release_notes.md

@@ -256,6 +256,8 @@ Please refer to the [Changelog][active-job] for detailed changes.
 
 *   Remove deprecated `ActiveRecord::Base.connection_config`.
 
+*   Remove deprecated `ActiveRecord::Base.arel_attribute`.
+
 ### Deprecations
 
 *   Deprecated `Rails.config.active_job.skip_after_callbacks_if_terminated`.