Deprecate passing a Time object to Time#since

Ref: rails#52343

`Time.now.since(Time.now)` does not fail, but it returns a random future
date (currently in 2079).

This commit deprecates passing a Time object to Time#since until Rails
8.0, where it will raise a TypeError.

Author: Schwad

activesupport/lib/active_support/core_ext/time/calculations.rb

@@ -217,7 +217,11 @@ def ago(seconds)
   # Returns a new Time representing the time a number of seconds since the instance time
   def since(seconds)
     self + seconds
-  rescue
+  rescue TypeError
+    ActiveSupport.deprecator.warn(
+      "Passing an instance of #{seconds.class} to #{self.class}#since is deprecated. This behavior will raise " \
+      "a `TypeError` in Rails 8.1."
+    )
     to_datetime.since(seconds)
   end
   alias :in :since

activesupport/test/core_ext/time_ext_test.rb

@@ -282,6 +282,12 @@ def test_daylight_savings_time_crossings_backward_end_1day
     end
   end
 
+  def test_since_with_instance_of_time_deprecated
+    assert_deprecated(ActiveSupport.deprecator) do
+      Time.now.since(Time.now)
+    end
+  end
+
   def test_since
     assert_equal Time.local(2005, 2, 22, 10, 10, 11), Time.local(2005, 2, 22, 10, 10, 10).since(1)
     assert_equal Time.local(2005, 2, 22, 11, 10, 10), Time.local(2005, 2, 22, 10, 10, 10).since(3600)