Merge pull request rails#53153 from zzak/asto-registry-inspect

Add inspect to ActiveStorage::Service, ActiveStorage::Service::Registry, and ActiveStorage::Service::Configurator

Author: byroot

activestorage/lib/active_storage/service.rb

@@ -148,6 +148,10 @@ def public?
       @public
     end
 
+    def inspect # :nodoc:
+      "#<#{self.class}#{name.present? ? " name=#{name.inspect}" : ""}>"
+    end
+
     private
       def private_url(key, expires_in:, filename:, disposition:, content_type:, **)
         raise NotImplementedError

activestorage/lib/active_storage/service/configurator.rb

@@ -19,6 +19,12 @@ def build(service_name)
       )
     end
 
+    def inspect # :nodoc:
+      attrs = configurations.any? ?
+        " configurations=[#{configurations.keys.map(&:inspect).join(", ")}]" : ""
+      "#<#{self.class}#{attrs}>"
+    end
+
     private
       def config_for(name)
         configurations.fetch name do

activestorage/lib/active_storage/service/registry.rb

@@ -22,6 +22,12 @@ def fetch(name)
       end
     end
 
+    def inspect # :nodoc:
+      attrs = configurations.any? ?
+        " configurations=[#{configurations.keys.map(&:inspect).join(", ")}]" : ""
+      "#<#{self.class}#{attrs}>"
+    end
+
     private
       attr_reader :configurations, :services
 

activestorage/test/service/configurator_test.rb

@@ -21,6 +21,19 @@ class ActiveStorage::Service::ConfiguratorTest < ActiveSupport::TestCase
     end
   end
 
+  test "inspect attributes" do
+    config = {
+      local: { service: "Disk", root: "/tmp/active_storage_configurator_test" },
+      tmp: { service: "Disk", root: "/tmp/active_storage_configurator_test_tmp" },
+    }
+
+    configurator = ActiveStorage::Service::Configurator.new(config)
+    assert_match(/#<ActiveStorage::Service::Configurator configurations=\[:local, :tmp\]>/, configurator.inspect)
+
+    configurator = ActiveStorage::Service::Configurator.new({})
+    assert_match(/#<ActiveStorage::Service::Configurator>/, configurator.inspect)
+  end
+
   test "azure service is deprecated" do
     msg = <<~MSG.squish
       `ActiveStorage::Service::AzureStorageService` is deprecated and will be

activestorage/test/service/registry_test.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ActiveStorage::Service::RegistryTest < ActiveSupport::TestCase
+  test "inspect attributes" do
+    registry = ActiveStorage::Service::Registry.new({})
+    assert_match(/#<ActiveStorage::Service::Registry>/, registry.inspect)
+  end
+
+  test "inspect attributes with config" do
+    config = {
+      local: { service: "Disk", root: "/tmp/active_storage_registry_test" },
+      tmp: { service: "Disk", root: "/tmp/active_storage_registry_test_tmp" },
+    }
+
+    registry = ActiveStorage::Service::Registry.new(config)
+    assert_match(/#<ActiveStorage::Service::Registry configurations=\[:local, :tmp\]>/, registry.inspect)
+  end
+end

activestorage/test/service_test.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ActiveStorage::ServiceTest < ActiveSupport::TestCase
+  test "inspect attributes" do
+    config = {
+      local: { service: "Disk", root: "/tmp/active_storage_service_test" },
+      tmp: { service: "Disk", root: "/tmp/active_storage_service_test_tmp" },
+    }
+
+    service = ActiveStorage::Service.configure(:local, config)
+    assert_match(/#<ActiveStorage::Service::DiskService name=:local>/, service.inspect)
+
+    service = ActiveStorage::Service.new
+    assert_match(/#<ActiveStorage::Service>/, service.inspect)
+  end
+end