Merge pull request rails#54354 from joshuay03/name-all-thread-pool-executors

Add names to all `Concurrent::ThreadPoolExecutor`s

Author: byroot

actioncable/lib/action_cable/connection/stream_event_loop.rb

@@ -68,6 +68,7 @@ def spawn
             @nio ||= NIO::Selector.new
 
             @executor ||= Concurrent::ThreadPoolExecutor.new(
+              name: "ActionCable-streamer",
               min_threads: 1,
               max_threads: 10,
               max_queue: 0,

actioncable/lib/action_cable/server/worker.rb

@@ -20,7 +20,7 @@ class Worker # :nodoc:
 
       def initialize(max_size: 5)
         @executor = Concurrent::ThreadPoolExecutor.new(
-          name: "ActionCable",
+          name: "ActionCable-server",
           min_threads: 1,
           max_threads: max_size,
           max_queue: 0,

activejob/lib/active_job/queue_adapters/async_adapter.rb

@@ -86,7 +86,11 @@ class Scheduler # :nodoc:
         def initialize(**options)
           self.immediate = false
           @immediate_executor = Concurrent::ImmediateExecutor.new
-          @async_executor = Concurrent::ThreadPoolExecutor.new(DEFAULT_EXECUTOR_OPTIONS.merge(options))
+          @async_executor = Concurrent::ThreadPoolExecutor.new(
+            name: "ActiveJob-async-scheduler",
+            **DEFAULT_EXECUTOR_OPTIONS,
+            **options
+          )
         end
 
         def enqueue(job, queue_name:)

activerecord/lib/active_record.rb

@@ -288,6 +288,7 @@ def self.db_warnings_action=(action)
   def self.global_thread_pool_async_query_executor # :nodoc:
     concurrency = global_executor_concurrency || 4
     @global_thread_pool_async_query_executor ||= Concurrent::ThreadPoolExecutor.new(
+      name: "ActiveRecord-global-async-query-executor",
       min_threads: 0,
       max_threads: concurrency,
       max_queue: concurrency * 4,

activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb

@@ -276,8 +276,8 @@ def initialize(pool_config)
       end
 
       def inspect # :nodoc:
-        name_field = " name=#{db_config.name.inspect}" unless db_config.name == "primary"
-        shard_field = " shard=#{@shard.inspect}" unless @shard == :default
+        name_field = " name=#{name_inspect}" if name_inspect
+        shard_field = " shard=#{shard_inspect}" if shard_inspect
 
         "#<#{self.class.name} env_name=#{db_config.env_name.inspect}#{name_field} role=#{role.inspect}#{shard_field}>"
       end
@@ -715,7 +715,9 @@ def build_async_executor
           case ActiveRecord.async_query_executor
           when :multi_thread_pool
             if @db_config.max_threads > 0
+              name_with_shard = [name_inspect, shard_inspect].join("-").tr("_", "-")
               Concurrent::ThreadPoolExecutor.new(
+                name: "ActiveRecord-#{name_with_shard}-async-query-executor",
                 min_threads: @db_config.min_threads,
                 max_threads: @db_config.max_threads,
                 max_queue: @db_config.max_queue,
@@ -949,6 +951,14 @@ def checkout_and_verify(c)
           c.disconnect!
           raise
         end
+
+        def name_inspect
+          db_config.name.inspect unless db_config.name == "primary"
+        end
+
+        def shard_inspect
+          shard.inspect unless shard == :default
+        end
     end
   end
 end

activestorage/lib/active_storage/service/mirror_service.rb

@@ -30,6 +30,7 @@ def self.build(primary:, mirrors:, name:, configurator:, **options) # :nodoc:
     def initialize(primary:, mirrors:)
       @primary, @mirrors = primary, mirrors
       @executor = Concurrent::ThreadPoolExecutor.new(
+        name: "ActiveStorage-mirror-service",
         min_threads: 1,
         max_threads: mirrors.size,
         max_queue: 0,