Skip to content

Commit f6f2b2d

Browse files
authored
Merge pull request rails#48406 from rails/revert-46790-singular-association-refactor
Revert "Small refactor on build singular association"
2 parents 3e01b26 + 7f1c93b commit f6f2b2d

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

activerecord/lib/active_record/associations/has_one_association.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ def set_new_record(record)
9292
replace(record, false)
9393
end
9494

95-
def replace_keys(record, force: false)
96-
# Has one association doesn't have foreign keys to replace.
97-
end
98-
9995
def remove_target!(method)
10096
case method
10197
when :delete

activerecord/lib/active_record/associations/singular_association.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def _create_record(attributes, raise_error = false, &block)
5757
reflection.klass.transaction do
5858
record = build(attributes, &block)
5959
saved = record.save
60-
replace_keys(record, force: true)
60+
set_new_record(record)
6161
raise RecordInvalid.new(record) if !saved && raise_error
6262
record
6363
end

0 commit comments

Comments
 (0)