Return blob/blobs when #attach is able to save the record and return if it is not able to

Author: ghousemohamed

activestorage/CHANGELOG.md

@@ -1,3 +1,13 @@
+*   Saving attachment(s) to a record returns the blob/blobs object
+
+    Previously, saving attachments did not return the blob/blobs that
+    were attached. Now, saving attachments to a record with `#attach`
+    method returns the blob or array of blobs that were attached to
+    the record. If it fails to save the attachment(s), then it returns
+    `false`.
+
+    *Ghouse Mohamed*
+
 *   Don't stream responses in redirect mode
 
     Previously, both redirect mode and proxy mode streamed their

activestorage/lib/active_storage/attached/many.rb

@@ -49,8 +49,11 @@ def blobs
     def attach(*attachables)
       if record.persisted? && !record.changed?
         record.public_send("#{name}=", blobs + attachables.flatten)
-        return record.public_send("#{name}") if record.save
-        false
+        if record.save
+          record.public_send("#{name}")
+        else
+          false
+        end
       else
         record.public_send("#{name}=", (change&.attachables || blobs) + attachables.flatten)
       end

activestorage/lib/active_storage/attached/one.rb

@@ -56,8 +56,11 @@ def blank?
     def attach(attachable)
       if record.persisted? && !record.changed?
         record.public_send("#{name}=", attachable)
-        return record.public_send("#{name}") if record.save
-        false
+        if record.save
+          record.public_send("#{name}")
+        else
+          false
+        end
       else
         record.public_send("#{name}=", attachable)
       end