Skip to content

Commit fd1c635

Browse files
flavorjonesbyroot
authored andcommitted
Allow sqlite3 to float to version 2
1 parent c532443 commit fd1c635

File tree

7 files changed

+14
-10
lines changed

7 files changed

+14
-10
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ platforms :ruby, :windows do
154154
gem "racc", ">=1.4.6", require: false
155155

156156
# Active Record.
157-
gem "sqlite3", "~> 1.6", ">= 1.6.6"
157+
gem "sqlite3", ">= 1.6.6"
158158

159159
group :db do
160160
gem "pg", "~> 1.3"

Gemfile.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ GEM
327327
mixlib-shellout
328328
mini_magick (4.12.0)
329329
mini_mime (1.1.5)
330-
mini_portile2 (2.8.5)
330+
mini_portile2 (2.8.6)
331331
minitest (5.21.1)
332332
minitest-bisect (1.7.0)
333333
minitest-server (~> 1.0)
@@ -525,10 +525,10 @@ GEM
525525
actionpack (>= 5.2)
526526
activesupport (>= 5.2)
527527
sprockets (>= 3.0.0)
528-
sqlite3 (1.7.0)
528+
sqlite3 (2.0.0)
529529
mini_portile2 (~> 2.8.0)
530-
sqlite3 (1.7.0-x86_64-darwin)
531-
sqlite3 (1.7.0-x86_64-linux)
530+
sqlite3 (2.0.0-x86_64-darwin)
531+
sqlite3 (2.0.0-x86_64-linux-gnu)
532532
stackprof (0.2.25)
533533
stimulus-rails (1.3.0)
534534
railties (>= 6.0.0)
@@ -654,7 +654,7 @@ DEPENDENCIES
654654
sidekiq
655655
sneakers
656656
sprockets-rails (>= 2.0.0)
657-
sqlite3 (~> 1.6, >= 1.6.6)
657+
sqlite3 (>= 1.6.6)
658658
stackprof
659659
stimulus-rails
660660
sucker_punch

activerecord/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Allow `Sqlite3Adapter` to use `sqlite3` gem version `2.x`
2+
3+
*Mike Dalessio*
4+
15
* Allow `ActiveRecord::Base#pluck` to accept hash values
26

37
```ruby

activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
require "active_record/connection_adapters/sqlite3/schema_dumper"
1212
require "active_record/connection_adapters/sqlite3/schema_statements"
1313

14-
gem "sqlite3", "~> 1.4"
14+
gem "sqlite3", ">= 1.4"
1515
require "sqlite3"
1616

1717
module ActiveRecord

railties/lib/rails/generators/database.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def gem_for_database(database = options[:database])
1616
when "mysql" then ["mysql2", ["~> 0.5"]]
1717
when "trilogy" then ["trilogy", ["~> 2.7"]]
1818
when "postgresql" then ["pg", ["~> 1.1"]]
19-
when "sqlite3" then ["sqlite3", ["~> 1.4"]]
19+
when "sqlite3" then ["sqlite3", [">= 1.4"]]
2020
when "oracle" then ["activerecord-oracle_enhanced-adapter", nil]
2121
when "sqlserver" then ["activerecord-sqlserver-adapter", nil]
2222
when "jdbcmysql" then ["activerecord-jdbcmysql-adapter", nil]

railties/test/generators/app_generator_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ def test_config_database_is_added_by_default
441441
if defined?(JRUBY_VERSION)
442442
assert_gem "activerecord-jdbcsqlite3-adapter"
443443
else
444-
assert_gem "sqlite3", '"~> 1.4"'
444+
assert_gem "sqlite3", '">= 1.4"'
445445
end
446446
end
447447

railties/test/generators/db_system_change_generator_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class ChangeGeneratorTest < Rails::Generators::TestCase
128128

129129
assert_file("Gemfile") do |content|
130130
assert_match "# Use sqlite3 as the database for Active Record", content
131-
assert_match 'gem "sqlite3", "~> 1.4"', content
131+
assert_match 'gem "sqlite3", ">= 1.4"', content
132132
end
133133

134134
assert_file("Dockerfile") do |content|

0 commit comments

Comments
 (0)