Merge branch 'main' into skiaview

Author: wcandillon

docs/docs/animations/reanimated2.md

@@ -21,7 +21,7 @@ In the example below, the animation runs on the JS thread due to the use of Rean
 
 ```tsx twoslash
 import {useEffect} from "react";
-import {Canvas, Rect, mix, useValue} from "@shopify/react-native-skia";
+import {Canvas, Rect, mix} from "@shopify/react-native-skia";
 import {useSharedValue, withRepeat, withTiming, useDerivedValue} from "react-native-reanimated";
 
 const MyComponent = () => {

docs/docs/shapes/custom-drawing.md

@@ -54,7 +54,6 @@ const sidebars = {
         "shapes/vertices",
         "shapes/patch",
         "shapes/pictures",
-        "shapes/custom-drawing",
       ],
     },
     {

docs/sidebars.js

@@ -10,7 +10,6 @@
 #include "JsiHostObject.h"
 #include "JsiValueWrapper.h"
 #include "RNSkPlatformContext.h"
-#include "RNSkValue.h"
 #include "RNSkView.h"
 #include <jsi/jsi.h>
 
@@ -178,59 +177,8 @@ class RNSkJsiViewApi : public RNJsi::JsiHostObject,
     return jsi::Value::undefined();
   }
 
-  JSI_HOST_FUNCTION(registerValuesInView) {
-    // Check params
-    if (!arguments[1].isObject() ||
-        !arguments[1].asObject(runtime).isArray(runtime)) {
-      throw jsi::JSError(runtime,
-                         "Expected array of Values as second parameter");
-      return jsi::Value::undefined();
-    }
-
-    // Get identifier of native SkiaView
-    int nativeId = arguments[0].asNumber();
-
-    // Get values that should be added as dependencies
-    auto values = arguments[1].asObject(runtime).asArray(runtime);
-    std::vector<std::function<void()>> unsubscribers;
-    const std::size_t size = values.size(runtime);
-    unsubscribers.reserve(size);
-    for (size_t i = 0; i < size; ++i) {
-      auto value = values.getValueAtIndex(runtime, i)
-                       .asObject(runtime)
-                       .asHostObject<RNSkReadonlyValue>(runtime);
-
-      if (value != nullptr) {
-        // Add change listener
-        unsubscribers.push_back(value->addListener(
-            [weakSelf = weak_from_this(), nativeId](jsi::Runtime &) {
-              auto self = weakSelf.lock();
-              if (self) {
-                auto info = self->getEnsuredViewInfo(nativeId);
-                if (info->view != nullptr) {
-                  info->view->requestRedraw();
-                }
-              }
-            }));
-      }
-    }
-
-    // Return unsubscribe method that unsubscribes to all values
-    // that we subscribed to.
-    return jsi::Function::createFromHostFunction(
-        runtime, jsi::PropNameID::forUtf8(runtime, "unsubscribe"), 0,
-        JSI_HOST_FUNCTION_LAMBDA {
-          // decrease dependency count on the Skia View
-          for (auto &unsub : unsubscribers) {
-            unsub();
-          }
-          return jsi::Value::undefined();
-        });
-  }
-
   JSI_EXPORT_FUNCTIONS(JSI_EXPORT_FUNC(RNSkJsiViewApi, setJsiProperty),
                        JSI_EXPORT_FUNC(RNSkJsiViewApi, callJsiMethod),
-                       JSI_EXPORT_FUNC(RNSkJsiViewApi, registerValuesInView),
                        JSI_EXPORT_FUNC(RNSkJsiViewApi, requestRedraw),
                        JSI_EXPORT_FUNC(RNSkJsiViewApi, makeImageSnapshot))
 

package/cpp/rnskia/RNSkAnimation.h

@@ -7,7 +7,6 @@
 
 #include <JsiSkApi.h>
 #include <RNSkJsiViewApi.h>
-#include <RNSkValueApi.h>
 #include <RNSkView.h>
 
 #include <JsiDomApi.h>
@@ -80,11 +79,6 @@ void RNSkManager::installBindings() {
       *_jsRuntime, "SkiaViewApi",
       jsi::Object::createFromHostObject(*_jsRuntime, _viewApi));
 
-  auto skiaValueApi = std::make_shared<RNSkValueApi>(_platformContext);
-  _jsRuntime->global().setProperty(
-      *_jsRuntime, "SkiaValueApi",
-      jsi::Object::createFromHostObject(*_jsRuntime, std::move(skiaValueApi)));
-
   auto skiaDomApi = std::make_shared<JsiDomApi>(_platformContext);
   _jsRuntime->global().setProperty(
       *_jsRuntime, "SkiaDomApi",