Remove references of asBool (#2022)

Author: wcandillon

package/cpp/api/JsiSkParagraphStyle.h

@@ -24,6 +24,7 @@ namespace RNSkia {
 namespace jsi = facebook::jsi;
 
 namespace para = skia::textlayout;
+
 /**
  Implementation of the ParagraphStyle object in JSI
  */
@@ -60,7 +61,7 @@ class JsiSkParagraphStyle {
 
     if (object.hasProperty(runtime, "disableHinting")) {
       auto propValue = object.getProperty(runtime, "disableHinting");
-      if (propValue.asBool()) {
+      if (asBool(runtime, propValue)) {
         retVal.turnHintingOff();
       }
     }
@@ -83,7 +84,7 @@ class JsiSkParagraphStyle {
     }
     if (object.hasProperty(runtime, "replaceTabCharacters")) {
       auto propValue = object.getProperty(runtime, "replaceTabCharacters");
-      retVal.setReplaceTabCharacters(propValue.asBool());
+      retVal.setReplaceTabCharacters(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "textAlign")) {
       auto propValue = object.getProperty(runtime, "textAlign");

package/cpp/api/JsiSkStrutStyle.h

@@ -20,6 +20,13 @@ namespace jsi = facebook::jsi;
 
 namespace para = skia::textlayout;
 
+bool asBool(jsi::Runtime &runtime, const jsi::Value &value) {
+  if (!value.isBool()) {
+    throw jsi::JSError(runtime, "Expected boolean value");
+  }
+  return value.getBool();
+}
+
 /**
  Implementation of the TextStyle object in JSI for the paragraph builder
  */
@@ -47,7 +54,7 @@ class JsiSkStrutStyle {
 
     if (object.hasProperty(runtime, "strutEnabled")) {
       auto propValue = object.getProperty(runtime, "strutEnabled");
-      retVal.setStrutEnabled(propValue.asBool());
+      retVal.setStrutEnabled(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "fontFamilies")) {
       auto propValue = object.getProperty(runtime, "fontFamilies")
@@ -78,15 +85,15 @@ class JsiSkStrutStyle {
     }
     if (object.hasProperty(runtime, "halfLeading")) {
       auto propValue = object.getProperty(runtime, "halfLeading");
-      retVal.setHalfLeading(propValue.asBool());
+      retVal.setHalfLeading(asBool(runtime, propValue));
     }
     if (object.hasProperty(runtime, "leading")) {
       auto propValue = object.getProperty(runtime, "leading");
       retVal.setLeading(propValue.asNumber());
     }
     if (object.hasProperty(runtime, "forceStrutHeight")) {
       auto propValue = object.getProperty(runtime, "forceStrutHeight");
-      retVal.setForceStrutHeight(propValue.asBool());
+      retVal.setForceStrutHeight(asBool(runtime, propValue));
     }
 
     return retVal;