💚

wcandillon · wcandillon · commit 15c5ec75a639 · 2023-12-19T22:14:17.000+01:00
diff --git a/package/cpp/rnskia/dom/props/FontProp.h b/package/cpp/rnskia/dom/props/FontProp.h
@@ -31,8 +31,10 @@ class FontProp : public DerivedProp<SkFont> {
             "Expected SkFont object or null/undefined for the Font property.");
       }
     } else {
-      auto font = std::make_shared<SkFont>(SkFont());
-      font->setSize(14);
+	  auto fm = SkFontMgr::RefDefault();
+	  sk_sp<SkTypeface> typeface = fm->legacyMakeTypeface(nullptr, SkFontStyle());
+	  auto font = std::make_shared<SkFont>(SkFont(typeface));
+	  font->setSize(14);
       setDerivedValue(font);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,10 @@ class FontProp : public DerivedProp<SkFont> {`
`31`	`31`	`"Expected SkFont object or null/undefined for the Font property.");`
`32`	`32`	`}`
`33`	`33`	`} else {`
`34`		`- auto font = std::make_shared<SkFont>(SkFont());`
`35`		`- font->setSize(14);`
	`34`	`+ auto fm = SkFontMgr::RefDefault();`
	`35`	`+ sk_sp<SkTypeface> typeface = fm->legacyMakeTypeface(nullptr, SkFontStyle());`
	`36`	`+ auto font = std::make_shared<SkFont>(SkFont(typeface));`
	`37`	`+ font->setSize(14);`
`36`	`38`	`setDerivedValue(font);`
`37`	`39`	`}`
`38`	`40`	`}`