Skip to content

Commit 8b4581c

Browse files
authored
fix bug in documentation building (#2620)
1 parent d51beb3 commit 8b4581c

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

.github/workflows/build-npm.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,17 @@ jobs:
2525
with:
2626
github_token: ${{ secrets.GITHUB_TOKEN }}
2727

28+
- name: Build package and documentation
29+
run: yarn build
30+
2831
- name: Build NPM Package
2932
working-directory: packages/skia
3033
run: |
31-
yarn build
3234
npx semantic-release
3335
env:
3436
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3537
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
3638

37-
- name: Install & Build Docs
38-
run: cd apps/docs; yarn build;
39-
4039
- name: Deploy to GitHub Pages
4140
uses: peaceiris/actions-gh-pages@v3
4241
with:

.github/workflows/ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,14 @@ jobs:
7474
- name: Build package
7575
run: yarn build
7676

77+
- name: Build dry run release
78+
working-directory: packages/skia
79+
run: |
80+
npx semantic-release --dry-run
81+
env:
82+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
83+
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
84+
7785
build-android-ubuntu:
7886
runs-on: ubuntu-latest
7987
continue-on-error: true

apps/docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"@docusaurus/core": "2.4.3",
2020
"@docusaurus/preset-classic": "2.4.3",
2121
"@mdx-js/react": "^1.6.21",
22-
"@shopify/react-native-skia": "link:../package/",
22+
"@shopify/react-native-skia": "workspace:*",
2323
"@svgr/webpack": "^5.5.0",
2424
"clsx": "^1.1.1",
2525
"docusaurus-preset-shiki-twoslash": "1.1.41",

yarn.lock

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3721,12 +3721,6 @@ __metadata:
37213721
languageName: node
37223722
linkType: hard
37233723

3724-
"@shopify/react-native-skia@link:../package/::locator=docs%40workspace%3Aapps%2Fdocs":
3725-
version: 0.0.0-use.local
3726-
resolution: "@shopify/react-native-skia@link:../package/::locator=docs%40workspace%3Aapps%2Fdocs"
3727-
languageName: node
3728-
linkType: soft
3729-
37303724
"@shopify/react-native-skia@workspace:*, @shopify/react-native-skia@workspace:packages/skia":
37313725
version: 0.0.0-use.local
37323726
resolution: "@shopify/react-native-skia@workspace:packages/skia"
@@ -7734,7 +7728,7 @@ __metadata:
77347728
"@docusaurus/module-type-aliases": 2.4.3
77357729
"@docusaurus/preset-classic": 2.4.3
77367730
"@mdx-js/react": ^1.6.21
7737-
"@shopify/react-native-skia": "link:../package/"
7731+
"@shopify/react-native-skia": "workspace:*"
77387732
"@svgr/webpack": ^5.5.0
77397733
"@tsconfig/docusaurus": ^1.0.4
77407734
clsx: ^1.1.1

0 commit comments

Comments
 (0)