Skip to content

Commit b5cd478

Browse files
authored
chore(🏗️): rename getScaledWidth/Height to getWidth/Height (#3271)
1 parent 781966b commit b5cd478

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

packages/skia/android/cpp/rnskia-android/RNSkOpenGLCanvasProvider.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ RNSkOpenGLCanvasProvider::RNSkOpenGLCanvasProvider(
3131

3232
RNSkOpenGLCanvasProvider::~RNSkOpenGLCanvasProvider() = default;
3333

34-
int RNSkOpenGLCanvasProvider::getScaledWidth() {
34+
int RNSkOpenGLCanvasProvider::getWidth() {
3535
if (_surfaceHolder) {
3636
return _surfaceHolder->getWidth();
3737
}
3838
return 0;
3939
}
4040

41-
int RNSkOpenGLCanvasProvider::getScaledHeight() {
41+
int RNSkOpenGLCanvasProvider::getHeight() {
4242
if (_surfaceHolder) {
4343
return _surfaceHolder->getHeight();
4444
}

packages/skia/android/cpp/rnskia-android/RNSkOpenGLCanvasProvider.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ class RNSkOpenGLCanvasProvider
2121

2222
~RNSkOpenGLCanvasProvider();
2323

24-
int getScaledWidth() override;
24+
int getWidth() override;
2525

26-
int getScaledHeight() override;
26+
int getHeight() override;
2727

2828
bool renderToCanvas(const std::function<void(SkCanvas *)> &cb) override;
2929

packages/skia/apple/RNSkMetalCanvasProvider.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ class RNSkMetalCanvasProvider : public RNSkia::RNSkCanvasProvider {
2121

2222
~RNSkMetalCanvasProvider();
2323

24-
int getScaledWidth() override;
25-
int getScaledHeight() override;
24+
int getWidth() override;
25+
int getHeight() override;
2626

2727
bool renderToCanvas(const std::function<void(SkCanvas *)> &cb) override;
2828

packages/skia/apple/RNSkMetalCanvasProvider.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@
3737
/**
3838
Returns the scaled width of the view
3939
*/
40-
int RNSkMetalCanvasProvider::getScaledWidth() {
40+
int RNSkMetalCanvasProvider::getWidth() {
4141
return _ctx ? _ctx->getWidth() : -1;
4242
};
4343

4444
/**
4545
Returns the scaled height of the view
4646
*/
47-
int RNSkMetalCanvasProvider::getScaledHeight() {
47+
int RNSkMetalCanvasProvider::getHeight() {
4848
return _ctx ? _ctx->getHeight() : -1;
4949
};
5050

packages/skia/cpp/rnskia/RNSkView.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ class RNSkCanvasProvider {
3333
/**
3434
Returns the scaled width of the view
3535
*/
36-
virtual int getScaledWidth() = 0;
36+
virtual int getWidth() = 0;
3737

3838
/**
3939
Returns the scaled height of the view
4040
*/
41-
virtual int getScaledHeight() = 0;
41+
virtual int getHeight() = 0;
4242

4343
/**
4444
Render to a canvas
@@ -104,12 +104,12 @@ class RNSkOffscreenCanvasProvider : public RNSkCanvasProvider {
104104
/**
105105
Returns the scaled width of the view
106106
*/
107-
int getScaledWidth() override { return _width; };
107+
int getWidth() override { return _width; };
108108

109109
/**
110110
Returns the scaled height of the view
111111
*/
112-
int getScaledHeight() override { return _height; };
112+
int getHeight() override { return _height; };
113113

114114
/**
115115
Render to a canvas
@@ -195,7 +195,7 @@ class RNSkView : public std::enable_shared_from_this<RNSkView> {
195195

196196
auto provider = std::make_shared<RNSkOffscreenCanvasProvider>(
197197
getPlatformContext(), std::bind(&RNSkView::requestRedraw, this),
198-
_canvasProvider->getScaledWidth(), _canvasProvider->getScaledHeight());
198+
_canvasProvider->getWidth(), _canvasProvider->getHeight());
199199

200200
_renderer->renderImmediate(provider);
201201
return provider->makeSnapshot(bounds);
@@ -206,12 +206,12 @@ class RNSkView : public std::enable_shared_from_this<RNSkView> {
206206
/**
207207
Returns the scaled width of the view
208208
*/
209-
int getScaledWidth() { return _canvasProvider->getScaledWidth(); }
209+
int getScaledWidth() { return _canvasProvider->getWidth(); }
210210

211211
/**
212212
Returns the scaled height of the view
213213
*/
214-
int getScaledHeight() { return _canvasProvider->getScaledHeight(); }
214+
int getScaledHeight() { return _canvasProvider->getHeight(); }
215215

216216
protected:
217217
std::shared_ptr<RNSkPlatformContext> getPlatformContext() {

0 commit comments

Comments
 (0)