feat(💚): macOS support (#3045)

Co-authored-by: William Candillon <[email protected]>

Author: Saadnajmi

packages/skia/apple/MetalWindowContext.mm

@@ -15,7 +15,11 @@
   _layer.framebufferOnly = NO;
   _layer.device = device;
   _layer.opaque = false;
+#if !TARGET_OS_OSX
   _layer.contentsScale = [UIScreen mainScreen].scale;
+#else
+  _layer.contentsScale = [NSScreen mainScreen].backingScaleFactor;
+#endif // !TARGET_OS_OSX
   _layer.pixelFormat = MTLPixelFormatBGRA8Unorm;
   _layer.contentsGravity = kCAGravityBottomLeft;
   _layer.drawableSize = CGSizeMake(width, height);

packages/skia/apple/RNSkApplePlatformContext.h

@@ -23,7 +23,11 @@ class RNSkApplePlatformContext : public RNSkPlatformContext {
   RNSkApplePlatformContext(
       RCTBridge *bridge,
       std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker)
+#if !TARGET_OS_OSX
       : RNSkPlatformContext(jsCallInvoker, [[UIScreen mainScreen] scale]) {
+#else
+      : RNSkPlatformContext(jsCallInvoker, [[NSScreen mainScreen] backingScaleFactor]) {
+#endif // !TARGET_OS_OSX
 
     // Create screenshot manager
     _screenshotService =

packages/skia/apple/RNSkMetalCanvasProvider.mm

@@ -63,8 +63,13 @@
   // NOTE: UIApplication.sharedApplication.applicationState can only be
   // accessed from the main thread so we need to check here.
   if ([[NSThread currentThread] isMainThread]) {
+#if !TARGET_OS_OSX
     auto state = UIApplication.sharedApplication.applicationState;
-    if (state == UIApplicationStateBackground) {
+    bool appIsBackgrounded = (state == UIApplicationStateBackground);
+#else
+    bool appIsBackgrounded = !NSApplication.sharedApplication.isActive;
+#endif // !TARGET_OS_OSX
+    if (appIsBackgrounded) {
       // Request a redraw in the next run loop callback
       _requestRedraw();
       // and don't draw now since it might cause errors in the metal renderer if

packages/skia/apple/SkiaPictureViewManager.mm

@@ -37,7 +37,11 @@ - (SkiaManager *)skiaManager {
   [(SkiaUIView *)view setOpaque:opaque];
 }
 
+#if !TARGET_OS_OSX
 - (UIView *)view {
+#else
+- (RCTUIView *)view {
+#endif // !TARGET_OS_OSX
   auto skManager = [[self skiaManager] skManager];
   // Pass SkManager as a raw pointer to avoid circular dependenciesr
   return [[SkiaUIView alloc]

packages/skia/apple/SkiaUIView.h

@@ -4,7 +4,11 @@
 #import <string>
 
 #import <CoreFoundation/CoreFoundation.h>
+#if !TARGET_OS_OSX
 #import <UIKit/UIKit.h>
+#else
+#import <React/RCTUIKit.h>
+#endif // !TARGET_OS_OSX
 
 #import "RNSkManager.h"
 #import "RNSkAppleView.h"
@@ -18,7 +22,11 @@
 #if RCT_NEW_ARCH_ENABLED
     RCTViewComponentView
 #else
+#if !TARGET_OS_OSX
     UIView
+#else
+    RCTUIView
+#endif // !TARGET_OS_OSX
 #endif // RCT_NEW_ARCH_ENABLED
 
 - (instancetype)

packages/skia/apple/SkiaUIView.mm

@@ -55,8 +55,12 @@ - (void)willInvalidateModules {
 
 #pragma mark Lifecycle
 
-- (void)willMoveToSuperview:(UIView *)newWindow {
-  if (newWindow != nullptr) {
+#if !TARGET_OS_OSX
+- (void)willMoveToSuperview:(UIView *)newSuperView {
+#else
+- (void)viewWillMoveToSuperview:(NSView *)newSuperView {
+#endif // !TARGET_OS_OSX
+  if (newSuperView != nullptr) {
     // Create implementation view when the parent view is set
     if (_impl == nullptr && _manager != nullptr) {
       _impl = _factory(_manager->getPlatformContext());

packages/skia/apple/ViewScreenshotService.h

@@ -1,7 +1,11 @@
 #pragma once
 
 #import <CoreFoundation/CoreFoundation.h>
+#if !TARGET_OS_OSX
 #import <UIKit/UIKit.h>
+#else
+#import <Appkit/Appkit.h>
+#endif // !TARGET_OS_OSX
 
 #import <React/RCTUIManager.h>
 

packages/skia/apple/ViewScreenshotService.mm

@@ -20,6 +20,7 @@ - (instancetype)initWithUiManager:(RCTUIManager *)uiManager {
 }
 
 - (sk_sp<SkImage>)screenshotOfViewWithTag:(NSNumber *)viewTag {
+#if !TARGET_OS_OSX
   // Find view corresponding to the tag
   auto view = [_uiManager viewForReactTag:viewTag];
   if (view == NULL) {
@@ -80,6 +81,9 @@ - (instancetype)initWithUiManager:(RCTUIManager *)uiManager {
 
   // ... and then create the SkImage itself!
   return SkImages::RasterFromData(info, skData, bytesPerRow);
+#else
+  return nullptr;
+#endif // !TARGET_OS_OSX
 }
 
 @end

packages/skia/react-native-skia.podspec

@@ -41,7 +41,7 @@ Pod::Spec.new do |s|
     "Christian Falch" => "[email protected]",
     "William Candillon" => "[email protected]"
   }
-  s.platforms    = { :ios => "13.0", :tvos => "13.0" }
+  s.platforms    = { :ios => "13.0", :tvos => "13.0", :osx => "11" }
   s.source       = { :git => "https://github.com/shopify/react-native-skia/react-native-skia.git", :tag => "#{s.version}" }
 
   s.requires_arc = true
@@ -54,7 +54,7 @@ Pod::Spec.new do |s|
 
   s.frameworks = ['MetalKit', 'AVFoundation', 'AVKit', 'CoreMedia']
 
-  s.vendored_frameworks = use_graphite ?
+  s.vendored_frameworks = use_graphite ? 
   base_frameworks + graphite_frameworks :
   base_frameworks