Skip to content

Add isCCW param for addCircle #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add isCCW param for addCircle #2663

wants to merge 3 commits into from

Conversation

just-dodo
Copy link

@just-dodo just-dodo commented Sep 30, 2024 •
edited
Loading

I just add isCCW param for addCircle method for Path

@just-dodo just-dodo marked this pull request as draft September 30, 2024 16:21
@just-dodo just-dodo marked this pull request as ready for review September 30, 2024 16:21
@just-dodo just-dodo closed this Sep 30, 2024
@just-dodo just-dodo reopened this Sep 30, 2024
@wcandillon
Copy link
Contributor

thanks a lot, could you add a test for it:

react-native-skia/packages/skia/src/renderer/__tests__/e2e/Paths.spec.tsx

Line 22 in fe24c03

it("can transform a path from a matrix array (1)", async () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-dodo @wcandillon