-
Notifications
You must be signed in to change notification settings - Fork 38
Labels
BugSomething isn't workingSomething isn't working
Description
Currenty, we search up the tree for .roast
when looking for .roast/initializers
, but for everything else we use $PWD/.roast
. This causes a problem where, if you have a parent .roast/initializers
and you hit one of the other bits of code that uses $PWD/.roast
(e.g. creating $PWD/.roast/cache
), we ignore the parent .roast/initializers
.
Example:
- I'm in
my-project/my-workflow
. - There's already a
my-project/.roast/initializers/important-thing.rb
. - I run
roast execute workflow.yml
, and it createsmy-project/my-workflow/.roast
so it can put acache
in there. - Subsequent runs of
roast
no longer findmy-project/.roast/initializers
, as we stop at the first existing.roast
, which was recently created for acache
.
Potential Solutions:
- Standardize on the
.roast
search behaviour we have for initializers.- We'd stop doing
$PWD/.roast
, and just search up the tree like we do for.roast/initializers
for any use of.roast
.
- We'd stop doing
- Standardize on
$PWD/.roast
.- This limits flexibility a little, and potentially litters the fs with
.roast
, I prefer the former option.
- This limits flexibility a little, and potentially litters the fs with
Metadata
Metadata
Assignees
Labels
BugSomething isn't workingSomething isn't working