Merge pull request #2 from Shopify/pz-remove-sorbet

Remove sorbet

Author: peterzhu2118

.github/workflows/main.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - '3.2.0'
+          - "3.2"
 
     steps:
     - uses: actions/checkout@v3
@@ -22,5 +22,3 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
-    - name: Run typecheck
-      run: bundle exec srb tc

.rubocop.yml

@@ -3,7 +3,6 @@ inherit_gem:
 
 require:
   - rubocop-minitest
-  - rubocop-sorbet
 
 AllCops:
   NewCops: enable

bin/tapioca

@@ -1,8 +1,5 @@
-# typed: strong
 # frozen_string_literal: true
 
-require "sorbet-runtime"
-
 require_relative "shopify_ruby_definitions/ruby_build"
 require_relative "shopify_ruby_definitions/ruby_versions"
 require_relative "shopify_ruby_definitions/version"

lib/shopify_ruby_definitions.rb

@@ -1,10 +1,7 @@
-# typed: strong
 # frozen_string_literal: true
 
 module ShopifyRubyDefinitions
   module RubyBuild
-    extend T::Sig
-
-    RUBY_BUILD_DIRECTORY = T.let(File.expand_path("../../../vendor/ruby-build", __FILE__), String)
+    RUBY_BUILD_DIRECTORY = File.expand_path("../../../vendor/ruby-build", __FILE__)
   end
 end

lib/shopify_ruby_definitions/ruby_build.rb

@@ -1,14 +1,10 @@
-# typed: strong
 # frozen_string_literal: true
 
 module ShopifyRubyDefinitions
   module RubyVersions
-    extend T::Sig
+    VERSIONS_DIRECTORY = File.join(RubyBuild::RUBY_BUILD_DIRECTORY, "share/ruby-build")
+    ALL_VERSIONS = Dir["#{VERSIONS_DIRECTORY}/*"].map { |f| File.basename(f) }
 
-    VERSIONS_DIRECTORY = T.let(File.join(RubyBuild::RUBY_BUILD_DIRECTORY, "share/ruby-build"), String)
-    ALL_VERSIONS = T.let(Dir["#{VERSIONS_DIRECTORY}/*"].map { |f| File.basename(f) }, T::Array[String])
-
-    sig { returns(T::Hash[String, String]) }
     def version_overrides
       {
         "head" => ruby_head_version,
@@ -27,23 +23,21 @@ def version_overrides
       }.freeze
     end
 
-    sig { params(version: String).returns(String) }
     def resolve_version(version)
       if version.match?(/\A\d+\.\d+\z/)
         pattern = /\A#{Regexp.escape(version)}\.(\d+)\z/
         versions = ALL_VERSIONS.grep(pattern)
         unless versions.empty?
-          version = T.must(versions.max_by { |v| T.must(v.match(pattern))[1].to_i })
+          version = versions.max_by { |v| v.match(pattern)[1].to_i }
         end
       end
       version_overrides.fetch(version, version)
     end
 
     private
 
-    sig { returns(String) }
     def ruby_head_version
-      T.must(ALL_VERSIONS.grep(/\A[\d\.]+-dev\z/).max)
+      ALL_VERSIONS.grep(/\A[\d\.]+-dev\z/).max
     end
   end
 end

lib/shopify_ruby_definitions/ruby_versions.rb

@@ -1,4 +1,3 @@
-# typed: strong
 # frozen_string_literal: true
 
 module ShopifyRubyDefinitions

lib/shopify_ruby_definitions/version.rb

@@ -27,11 +27,6 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency("sorbet-runtime")
-
   spec.add_development_dependency("rubocop-minitest")
   spec.add_development_dependency("rubocop-shopify")
-  spec.add_development_dependency("rubocop-sorbet")
-  spec.add_development_dependency("sorbet")
-  spec.add_development_dependency("tapioca")
 end