Skip to content

Commit 505f469

Browse files
authored
Upgrade Sorbet and fix visibility violations (#3650)
Upgrade Sorbet and fix visibility violations (#3650) ### Motivation Upgrade Sorbet and fix visibility related violations. Co-authored-by: vinistock <[email protected]>
1 parent b5b0e64 commit 505f469

File tree

3 files changed

+24
-21
lines changed

3 files changed

+24
-21
lines changed

Gemfile.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ GEM
8585
rubocop (>= 1)
8686
ruby-progressbar (1.13.0)
8787
ruby2_keywords (0.0.5)
88-
sorbet (0.5.12194)
89-
sorbet-static (= 0.5.12194)
90-
sorbet-runtime (0.5.12194)
91-
sorbet-static (0.5.12194-universal-darwin)
92-
sorbet-static (0.5.12194-x86_64-linux)
93-
sorbet-static-and-runtime (0.5.12194)
94-
sorbet (= 0.5.12194)
95-
sorbet-runtime (= 0.5.12194)
88+
sorbet (0.5.12221)
89+
sorbet-static (= 0.5.12221)
90+
sorbet-runtime (0.5.12221)
91+
sorbet-static (0.5.12221-universal-darwin)
92+
sorbet-static (0.5.12221-x86_64-linux)
93+
sorbet-static-and-runtime (0.5.12221)
94+
sorbet (= 0.5.12221)
95+
sorbet-runtime (= 0.5.12221)
9696
spoom (1.7.4)
9797
erubi (>= 1.10.0)
9898
prism (>= 0.28.0)

lib/ruby_indexer/lib/ruby_indexer/entry.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ def signatures
333333
end
334334

335335
class Method < Member
336+
# @override
336337
#: Array[Signature]
337338
attr_reader :signatures
338339

lib/ruby_lsp/base_server.rb

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,6 @@ def start
101101
end
102102
end
103103

104-
#: -> void
105-
def run_shutdown
106-
@incoming_queue.clear
107-
@outgoing_queue.clear
108-
@incoming_queue.close
109-
@outgoing_queue.close
110-
@cancelled_requests.clear
111-
112-
@worker.terminate
113-
@outgoing_dispatcher.terminate
114-
@store.clear
115-
end
116-
117104
# This method is only intended to be used in tests! Pops the latest response that would be sent to the client
118105
#: -> untyped
119106
def pop_response
@@ -132,6 +119,21 @@ def process_message(message)
132119
raise AbstractMethodInvokedError
133120
end
134121

122+
#: -> void
123+
def run_shutdown
124+
@incoming_queue.clear
125+
@outgoing_queue.clear
126+
@incoming_queue.close
127+
@outgoing_queue.close
128+
@cancelled_requests.clear
129+
130+
@worker.terminate
131+
@outgoing_dispatcher.terminate
132+
@store.clear
133+
end
134+
135+
private
136+
135137
# @abstract
136138
#: -> void
137139
def shutdown

0 commit comments

Comments
 (0)