Consider extra Minitest spec descriptions (#3688)

Author: vinistock

lib/ruby_lsp/listeners/spec_style.rb

@@ -117,10 +117,7 @@ def handle_describe(node)
 
       #: (Prism::CallNode) -> void
       def handle_example(node)
-        # Minitest formats the descriptions into test method names by using the count of examples with the description
-        # We are not guaranteed to discover examples in the exact order using static analysis, so we use the line number
-        # instead. Note that anonymous examples mixed with meta-programming will not be handled correctly
-        description = extract_description(node) || "anonymous"
+        description = extract_it_description(node)
         line = node.location.start_line - 1
         parent = latest_group
         return unless parent.is_a?(Requests::Support::TestItem)
@@ -141,16 +138,37 @@ def handle_example(node)
 
       #: (Prism::CallNode) -> String?
       def extract_description(node)
+        arguments = node.arguments&.arguments
+        return unless arguments
+
+        parts = arguments.map { |arg| extract_argument_content(arg) }
+        return if parts.empty?
+
+        parts.join("::")
+      end
+
+      #: (Prism::CallNode) -> String
+      def extract_it_description(node)
+        # Minitest formats the descriptions into test method names by using the count of examples with the description
+        # We are not guaranteed to discover examples in the exact order using static analysis, so we use the line number
+        # instead. Note that anonymous examples mixed with meta-programming will not be handled correctly
         first_argument = node.arguments&.arguments&.first
-        return unless first_argument
+        return "anonymous" unless first_argument
+
+        extract_argument_content(first_argument) || "anonymous"
+      end
 
-        case first_argument
+      #: (Prism::Node) -> String?
+      def extract_argument_content(arg)
+        case arg
         when Prism::StringNode
-          first_argument.content
+          arg.content
+        when Prism::SymbolNode
+          arg.value
         when Prism::ConstantReadNode, Prism::ConstantPathNode
-          constant_name(first_argument)
+          constant_name(arg)
         else
-          first_argument.slice
+          arg.slice
         end
       end
 

test/requests/discover_tests_test.rb

@@ -745,6 +745,30 @@ def test_other_thing; end
       end
     end
 
+    def test_spec_using_describe_with_additional_descriptions
+      source = <<~RUBY
+        describe(Foo, :extra_1, :extra_2) do
+          describe("#some_method") do
+            it("does something") do
+              assert(true)
+            end
+          end
+        end
+      RUBY
+
+      with_minitest_spec_configured(source) do |items|
+        assert_equal(["Foo::extra_1::extra_2"], items.map { |i| i[:id] })
+        assert_equal(
+          ["Foo::extra_1::extra_2::#some_method"],
+          items.dig(0, :children).map { |i| i[:id] },
+        )
+        assert_equal(
+          ["Foo::extra_1::extra_2::#some_method#test_0002_does something"],
+          items.dig(0, :children).dig(0, :children).map { |i| i[:id] },
+        )
+      end
+    end
+
     private
 
     def create_test_discovery_addon