Make sure all version managers implement the detect logic

Author: rafaelfranca

vscode/src/ruby.ts

@@ -40,23 +40,20 @@ interface ManagerClass {
     manuallySelectRuby: () => Promise<void>,
     ...args: any[]
   ): VersionManager;
-  detect?: (
-    workspaceFolder: vscode.WorkspaceFolder,
-    outputChannel: WorkspaceChannel,
-  ) => Promise<vscode.Uri | undefined>;
+  detect: (workspaceFolder: vscode.WorkspaceFolder, outputChannel: WorkspaceChannel) => Promise<vscode.Uri | undefined>;
 }
 
 const VERSION_MANAGERS: Record<ManagerIdentifier, ManagerClass> = {
+  [ManagerIdentifier.Shadowenv]: Shadowenv,
   [ManagerIdentifier.Asdf]: Asdf,
-  [ManagerIdentifier.Auto]: None, // Auto is handled specially
   [ManagerIdentifier.Chruby]: Chruby,
   [ManagerIdentifier.Rbenv]: Rbenv,
   [ManagerIdentifier.Rvm]: Rvm,
-  [ManagerIdentifier.Shadowenv]: Shadowenv,
   [ManagerIdentifier.Mise]: Mise,
   [ManagerIdentifier.RubyInstaller]: RubyInstaller,
-  [ManagerIdentifier.None]: None,
   [ManagerIdentifier.Custom]: Custom,
+  [ManagerIdentifier.Auto]: None, // Auto is handled specially
+  [ManagerIdentifier.None]: None, // None is last as the fallback
 };
 
 export class Ruby implements RubyInterface {
@@ -319,16 +316,19 @@ export class Ruby implements RubyInterface {
   }
 
   private async discoverVersionManager() {
-    // Check managers that have a detect() method
-    for (const [identifier, ManagerClass] of Object.entries(VERSION_MANAGERS)) {
-      if (ManagerClass.detect && (await ManagerClass.detect(this.workspaceFolder, this.outputChannel))) {
-        this.versionManager = identifier as ManagerIdentifier;
+    // Check all managers for detection
+    const entries = Object.entries(VERSION_MANAGERS) as [ManagerIdentifier, ManagerClass][];
+
+    for (const [identifier, ManagerClass] of entries) {
+      if (identifier === ManagerIdentifier.Auto) {
+        continue;
+      }
+
+      if (await ManagerClass.detect(this.workspaceFolder, this.outputChannel)) {
+        this.versionManager = identifier;
         return;
       }
     }
-
-    // If we can't find a version manager, just return None
-    this.versionManager = ManagerIdentifier.None;
   }
 
   private async handleRubyError(message: string) {

vscode/src/ruby/custom.ts

@@ -8,6 +8,14 @@ import { VersionManager, ActivationResult } from "./versionManager";
 // Users are allowed to define a shell script that runs before calling ruby, giving them the chance to modify the PATH,
 // GEM_HOME and GEM_PATH as needed to find the correct Ruby runtime.
 export class Custom extends VersionManager {
+  // eslint-disable-next-line @typescript-eslint/require-await
+  static async detect(
+    _workspaceFolder: vscode.WorkspaceFolder,
+    _outputChannel: vscode.LogOutputChannel,
+  ): Promise<vscode.Uri | undefined> {
+    return undefined;
+  }
+
   async activate(): Promise<ActivationResult> {
     const parsedResult = await this.runEnvActivationScript(`${this.customCommand()} && ruby`);
 

vscode/src/ruby/none.ts

@@ -13,6 +13,15 @@ import { VersionManager, ActivationResult } from "./versionManager";
 // If you don't have Ruby automatically available in your PATH and are not using a version manager, look into
 // configuring custom Ruby activation
 export class None extends VersionManager {
+  // eslint-disable-next-line @typescript-eslint/require-await
+  static async detect(
+    _workspaceFolder: vscode.WorkspaceFolder,
+    _outputChannel: vscode.LogOutputChannel,
+  ): Promise<vscode.Uri | undefined> {
+    // None always matches as the final fallback
+    return vscode.Uri.file("none");
+  }
+
   private readonly rubyPath: string;
 
   constructor(