Reorganize our ESlint and prettier configurations (#3648)

* Reorganize our ESlint and prettier configurations

* Auto-format files

* Fix type checking errors

Author: vinistock

vscode/.prettierrc.json

@@ -0,0 +1,7 @@
+{
+  "tabWidth": 2,
+  "printWidth": 120,
+  "semi": true,
+  "singleQuote": false,
+  "bracketSpacing": true
+}

vscode/eslint.config.mjs

@@ -1,40 +1,65 @@
-import shopifyPlugin from "@shopify/eslint-plugin";
+// @ts-check
 
-const config = [
-  ...shopifyPlugin.configs.core,
-  ...shopifyPlugin.configs.typescript,
-  ...shopifyPlugin.configs.prettier,
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+import eslintPluginPrettier from "eslint-plugin-prettier";
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  tseslint.configs.recommendedTypeChecked,
+  {
+    plugins: {
+      prettier: eslintPluginPrettier,
+    },
+    rules: {
+      "prettier/prettier": "warn",
+    },
+  },
   {
     languageOptions: {
       parserOptions: {
         projectService: true,
         tsconfigRootDir: import.meta.dirname,
       },
     },
-
-    "rules": {
-      "@typescript-eslint/no-floating-promises": "error",
+  },
+  {
+    ignores: [
+      "**/.vscode-test/**",
+      "eslint.config.mjs",
+      "**/out/",
+      "src/test/suite/fakeTestServer.js",
+    ],
+  },
+  {
+    rules: {
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+          varsIgnorePattern: "^_",
+          caughtErrorsIgnorePattern: "^_",
+        },
+      ],
       "consistent-return": "off",
       "no-warning-comments": "off",
       "no-console": "warn",
-      "@shopify/no-debugger": "warn",
       "no-template-curly-in-string": "warn",
       "eqeqeq": "error",
       "no-invalid-this": "error",
-      "no-lonely-if": "error",
-      "max-len": [
-        "error",
-        {
-          "code": 120
-        }
-      ]
+      "no-lonely-if": "error"
     }
   },
   {
-    ignores: [
-      ".vscode-test/*",
-    ],
+    files: ["**/*.test.ts"],
+    rules: {
+      "@typescript-eslint/no-unsafe-call": "off",
+    }
   }
-]
-
-export default config;
+);

vscode/package.json

@@ -802,8 +802,8 @@
     "compile": "tsc -p ./",
     "watch": "tsc -watch -p ./",
     "pretest": "yarn run compile",
-    "format": "eslint '**/*.ts' --fix && prettier '**/*.{json,md,yaml,yml}' --write",
-    "lint": "eslint '**/*.ts' --max-warnings=0 && prettier '**/*.{json,md,yaml,yml}' --check",
+    "format": "eslint . --fix && prettier '**/*.{ts,json,md,yaml,yml}' --write",
+    "lint": "eslint . && prettier '**/*.{ts,json,md,yaml,yml}' --check",
     "test": "node ./out/test/runTest.js"
   },
   "resolutions": {
@@ -813,30 +813,24 @@
   },
   "devDependencies": {
     "@babel/core": "^7.28.0",
-    "@eslint/eslintrc": "^3.3.1",
     "@eslint/js": "^9.30.1",
-    "@shopify/eslint-plugin": "^48.0.2",
-    "@shopify/prettier-config": "^1.1.4",
     "@types/glob": "^8.1.0",
     "@types/mocha": "^10.0.10",
     "@types/node": "24.x",
     "@types/sinon": "^17.0.4",
     "@types/vscode": "^1.91.0",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
     "@vscode/test-electron": "^2.5.2",
     "@vscode/vsce": "^3.6.0",
     "esbuild": "^0.25.5",
-    "eslint": "^8.57.0",
-    "eslint-import-resolver-typescript": "^4.4.4",
+    "eslint": "^9.30.1",
     "eslint-plugin-prettier": "^5.5.1",
     "glob": "^11.0.3",
     "mocha": "^11.7.1",
     "ovsx": "^0.10.4",
     "prettier": "^3.6.2",
     "sinon": "^21.0.0",
     "typescript": "^5.8.3",
-    "typescript-eslint": "8",
+    "typescript-eslint": "^8.35.1",
     "vscode-oniguruma": "^2.0.1",
     "vscode-textmate": "^9.2.0"
   },

vscode/src/chatAgent.ts

@@ -35,14 +35,8 @@ export class ChatAgent implements vscode.Disposable {
   private readonly agent: vscode.ChatParticipant;
   private readonly showWorkspacePick: () => Promise<Workspace | undefined>;
 
-  constructor(
-    context: vscode.ExtensionContext,
-    showWorkspacePick: () => Promise<Workspace | undefined>,
-  ) {
-    this.agent = vscode.chat.createChatParticipant(
-      CHAT_AGENT_ID,
-      this.handler.bind(this),
-    );
+  constructor(context: vscode.ExtensionContext, showWorkspacePick: () => Promise<Workspace | undefined>) {
+    this.agent = vscode.chat.createChatParticipant(CHAT_AGENT_ID, this.handler.bind(this));
     this.agent.iconPath = vscode.Uri.joinPath(context.extensionUri, "icon.png");
     this.showWorkspacePick = showWorkspacePick;
   }
@@ -62,9 +56,7 @@ export class ChatAgent implements vscode.Disposable {
       return this.runDesignCommand(request, context, stream, token);
     }
 
-    stream.markdown(
-      "Please indicate which command you would like to use for our chat.",
-    );
+    stream.markdown("Please indicate which command you would like to use for our chat.");
     return { metadata: { command: "" } };
   }
 
@@ -79,9 +71,7 @@ export class ChatAgent implements vscode.Disposable {
     const messages = [
       vscode.LanguageModelChatMessage.User(`User prompt: ${request.prompt}`),
       vscode.LanguageModelChatMessage.User(DESIGN_PROMPT),
-      vscode.LanguageModelChatMessage.User(
-        `Previous interactions with the user: ${previousInteractions}`,
-      ),
+      vscode.LanguageModelChatMessage.User(`Previous interactions with the user: ${previousInteractions}`),
     ];
     const workspace = await this.showWorkspacePick();
 
@@ -91,11 +81,7 @@ export class ChatAgent implements vscode.Disposable {
       const schema = await this.schema(workspace);
 
       if (schema) {
-        messages.push(
-          vscode.LanguageModelChatMessage.User(
-            `Existing application schema: ${schema}`,
-          ),
-        );
+        messages.push(vscode.LanguageModelChatMessage.User(`Existing application schema: ${schema}`));
       }
     }
 
@@ -153,7 +139,7 @@ export class ChatAgent implements vscode.Disposable {
         vscode.Uri.joinPath(workspace.workspaceFolder.uri, "db/schema.rb"),
       );
       return content.toString();
-    } catch (error) {
+    } catch (_error) {
       // db/schema.rb doesn't exist
     }
 
@@ -162,7 +148,7 @@ export class ChatAgent implements vscode.Disposable {
         vscode.Uri.joinPath(workspace.workspaceFolder.uri, "db/structure.sql"),
       );
       return content.toString();
-    } catch (error) {
+    } catch (_error) {
       // db/structure.sql doesn't exist
     }
 
@@ -171,32 +157,19 @@ export class ChatAgent implements vscode.Disposable {
 
   // Returns `true` if the current or any previous interactions with the chat match the given `command`. Useful for
   // ensuring that the user can continue chatting without having to re-type the desired command multiple times
-  private withinConversation(
-    command: string,
-    request: vscode.ChatRequest,
-    context: vscode.ChatContext,
-  ) {
+  private withinConversation(command: string, request: vscode.ChatRequest, context: vscode.ChatContext) {
     return (
       request.command === command ||
       (!request.command &&
-        context.history.some(
-          (entry) =>
-            entry instanceof vscode.ChatRequestTurn &&
-            entry.command === command,
-        ))
+        context.history.some((entry) => entry instanceof vscode.ChatRequestTurn && entry.command === command))
     );
   }
 
   // Default error handling
   private handleError(err: any, stream: vscode.ChatResponseStream) {
     if (err instanceof vscode.LanguageModelError) {
-      if (
-        err.cause instanceof Error &&
-        err.cause.message.includes("off_topic")
-      ) {
-        stream.markdown(
-          "Sorry, I can only help you with Ruby related questions",
-        );
+      if (err.cause instanceof Error && err.cause.message.includes("off_topic")) {
+        stream.markdown("Sorry, I can only help you with Ruby related questions");
       }
     } else {
       throw err;