Upgrade to Ruby 3.4.1 (#3003)

### Motivation

Starting the new year always means the same thing: new rubies! Upgrade to Ruby 3.4.1.

There were some tiny differences that I had to fix:

1. The output of hashes changed from the old rocket syntax to the new. We can't simply update the expectations because then tests will fail on <3.4
2. The locations of some syntax error diagnostics have changed. I switched to a hand written test to make it easy to account for different behaviours, but I kept the fixture so that non-raise expectations continue to run
3. The last one I'm unsure if it's a bug or an intentional change. Based on our document symbol test and implementation, it seems that in <3.4 `empty?` returns `true` if the contents of the string are just a line break. This doesn't seem to be the case anymore
4. Many default gems now became bundled gems. We now need to add `csv` and `base64` to the Jekyll bundle since the gem doesn't declare an explicit dependency on them, but they have been removed

Author: vinistock

.github/workflows/ci.yml

@@ -41,7 +41,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 30
     name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }}

.ruby-version

@@ -1 +1 @@
-3.3.4
+3.4.1

Gemfile.lock

@@ -146,4 +146,4 @@ DEPENDENCIES
   tapioca (~> 0.16)
 
 BUNDLED WITH
-   2.5.11
+   2.6.2

jekyll/Gemfile

@@ -9,3 +9,5 @@ gem "jekyll-feed", "~> 0.12"
 
 # Theme
 gem "just-the-docs", "~> 0.10.0"
+gem "csv"
+gem "base64"

jekyll/Gemfile.lock

@@ -3,41 +3,28 @@ GEM
   specs:
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
+    base64 (0.2.0)
     bigdecimal (3.1.8)
     colorator (1.1.0)
     concurrent-ruby (1.3.4)
+    csv (3.3.2)
     em-websocket (0.5.3)
       eventmachine (>= 0.12.9)
       http_parser.rb (~> 0)
     eventmachine (1.2.7)
-    ffi (1.17.0)
-    ffi (1.17.0-aarch64-linux-gnu)
-    ffi (1.17.0-aarch64-linux-musl)
-    ffi (1.17.0-arm-linux-gnu)
-    ffi (1.17.0-arm-linux-musl)
-    ffi (1.17.0-arm64-darwin)
-    ffi (1.17.0-x86-linux-gnu)
-    ffi (1.17.0-x86-linux-musl)
-    ffi (1.17.0-x86_64-darwin)
-    ffi (1.17.0-x86_64-linux-gnu)
-    ffi (1.17.0-x86_64-linux-musl)
+    ffi (1.17.1)
+    ffi (1.17.1-aarch64-linux-gnu)
+    ffi (1.17.1-aarch64-linux-musl)
+    ffi (1.17.1-arm-linux-gnu)
+    ffi (1.17.1-arm-linux-musl)
+    ffi (1.17.1-arm64-darwin)
+    ffi (1.17.1-x86-linux-gnu)
+    ffi (1.17.1-x86-linux-musl)
+    ffi (1.17.1-x86_64-darwin)
+    ffi (1.17.1-x86_64-linux-gnu)
+    ffi (1.17.1-x86_64-linux-musl)
     forwardable-extended (2.6.0)
-    google-protobuf (4.28.2)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.28.2-aarch64-linux)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.28.2-arm64-darwin)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.28.2-x86-linux)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.28.2-x86_64-darwin)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.28.2-x86_64-linux)
+    google-protobuf (4.29.2)
       bigdecimal
       rake (>= 13)
     http_parser.rb (0.8.0)
@@ -173,6 +160,8 @@ PLATFORMS
   x86_64-linux-musl
 
 DEPENDENCIES
+  base64
+  csv
   jekyll (~> 4.3.4)
   jekyll-feed (~> 0.12)
   just-the-docs (~> 0.10.0)

lib/ruby_lsp/listeners/document_symbol.rb

@@ -340,7 +340,7 @@ def on_alias_method_node_enter(node)
         ).returns(Interface::DocumentSymbol)
       end
       def create_document_symbol(name:, kind:, range_location:, selection_range_location:)
-        name = "<blank>" if name.empty?
+        name = "<blank>" if name.strip.empty?
         symbol = Interface::DocumentSymbol.new(
           name: name,
           kind: kind,

test/expectations/diagnostics/syntax_diagnostics.exp.json

@@ -156,7 +156,7 @@ def test_composed_bundle_includes_debug
             "bundle exec ruby -e 'require \"debug\"'",
           )
         end
-        assert_empty(stderr)
+        refute_match(/cannot load such file/, stderr)
       end
     end
   end

test/integration_test.rb

@@ -105,4 +105,41 @@ def run_diagnostic(uri, document)
     diagnostics = T.must(RubyLsp::Requests::Diagnostics.new(@global_state, document).perform)
     assert(diagnostics.find { |d| d.message == "Hello from custom formatter" })
   end
+
+  def test_ambiguous_syntax_warnings
+    document = RubyLsp::RubyDocument.new(source: <<~RUBY.chomp, version: 1, uri: URI("file:///fake/file.rb"))
+      b +a
+      b -a
+      b *a
+      b /a/
+    RUBY
+
+    diagnostics = T.must(RubyLsp::Requests::Diagnostics.new(@global_state, document).perform)
+    assert_match("ambiguous first argument", T.must(diagnostics[0]).message)
+    assert_match("ambiguous first argument", T.must(diagnostics[1]).message)
+    assert_match("ambiguous `*`", T.must(diagnostics[2]).message)
+    assert_match("ambiguous `/`", T.must(diagnostics[3]).message)
+  end
+
+  def test_END_inside_method_definition_warning
+    document = RubyLsp::RubyDocument.new(source: <<~RUBY.chomp, version: 1, uri: URI("file:///fake/file.rb"))
+      def m; END{}; end
+    RUBY
+
+    diagnostics = T.must(RubyLsp::Requests::Diagnostics.new(@global_state, document).perform)
+    assert_equal("END in method; use at_exit", T.must(diagnostics[0]).message)
+  end
+
+  def test_syntax_error_diagnostic
+    document = RubyLsp::RubyDocument.new(source: <<~RUBY.chomp, version: 1, uri: URI("file:///fake/file.rb"))
+      def foo
+    RUBY
+
+    diagnostics = T.must(RubyLsp::Requests::Diagnostics.new(@global_state, document).perform)
+    assert_equal("expected a delimiter to close the parameters", T.must(diagnostics[0]).message)
+    assert_equal(
+      "unexpected end-of-input, assuming it is closing the parent top level context",
+      T.must(diagnostics[1]).message,
+    )
+  end
 end

test/requests/diagnostics_test.rb

@@ -784,8 +784,8 @@ class Foo
       document.locate_node({ line: 3, character: 2 })
     end
 
-    assert_equal(<<~MESSAGE.chomp, error.message)
-      Requested position: {:line=>3, :character=>2}
+    assert_match(/Requested position: {(:)?line[\s:=>]+3, (:)?character[\s:=>]+2}/, error.message)
+    assert_match(<<~MESSAGE.chomp, error.message)
       Source:
 
       class Foo