Show full constant names on hover (#3457)

Author: vinistock

lib/ruby_lsp/listeners/hover.rb

@@ -366,9 +366,10 @@ def generate_hover(name, location)
         # We should only show hover for private constants if the constant is defined in the same namespace as the
         # reference
         first_entry = entries.first #: as !nil
-        return if first_entry.private? && first_entry.name != "#{@node_context.fully_qualified_name}::#{name}"
+        full_name = first_entry.name
+        return if first_entry.private? && full_name != "#{@node_context.fully_qualified_name}::#{name}"
 
-        categorized_markdown_from_index_entries(name, entries).each do |category, content|
+        categorized_markdown_from_index_entries(full_name, entries).each do |category, content|
           @response_builder.push(content, category: category)
         end
       end

test/requests/hover_expectations_test.rb

@@ -971,6 +971,46 @@ def with_foo(foo)
     end
   end
 
+  def test_hovering_constants_shows_complete_name
+    source = <<~RUBY
+      # typed: ignore
+      module Foo
+        CONST = 123
+
+        module Bar
+          class Baz; end
+
+          Baz
+        end
+      end
+
+      QUX = 42
+    RUBY
+
+    with_server(source) do |server, uri|
+      server.process_message(
+        id: 1,
+        method: "textDocument/hover",
+        params: { textDocument: { uri: uri }, position: { character: 4, line: 7 } },
+      )
+      assert_match("```ruby\nFoo::Bar::Baz\n```", server.pop_response.response.contents.value)
+
+      server.process_message(
+        id: 1,
+        method: "textDocument/hover",
+        params: { textDocument: { uri: uri }, position: { character: 2, line: 2 } },
+      )
+      assert_match("```ruby\nFoo::CONST\n```", server.pop_response.response.contents.value)
+
+      server.process_message(
+        id: 1,
+        method: "textDocument/hover",
+        params: { textDocument: { uri: uri }, position: { character: 0, line: 11 } },
+      )
+      assert_match("```ruby\nQUX\n```", server.pop_response.response.contents.value)
+    end
+  end
+
   private
 
   def create_hover_addon