Exclude certain Bundler settings when composing bundle#3277
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
### Motivation Closes #2440, closes #3196 Certain Bundler settings are better used only when the user is in control, like deciding when to package gems or if Bundler should automatically install binstubs for all gems. This PR starts ignoring certain settings from the composed environment. ### Implementation Added a list of ignored settings that we reject before building the environment that we'll use to run bundle install/update. ### Automated Tests Added tests for both bundle bin and bundle package related settings.
fbc65c7 to
81b238c
Compare
|
Following up to this, I noticed that Bundler has a
Would this be helpful? Are there any configuration values that we do want to preserve? |
|
@vinistock is there something that needs to be done to ensure this takes effect? I upgraded to v0.9.8 as soon as it was released, but am still seeing these gem package files show up in vendor/cache. |
|
v0.9.8 is the extension version, but the bug fix is in the server gem. Since this fix is in the LSP launcher, doing Running |
|
Hmm, I'm on v0.23.12 and am unfortunately still seeing these files get added to |
|
Indeed. I double-checked and I think #3342 will fix it. |

Motivation
Closes #2440, closes #3196
Certain Bundler settings are better used only when the user is in control, like deciding when to package gems or if Bundler should automatically install binstubs for all gems.
This PR starts ignoring certain settings from the composed environment.
Implementation
Added a list of ignored settings that we reject before building the environment that we'll use to run bundle install/update.
Automated Tests
Added tests for both bundle bin and bundle package related settings.