Skip to content

Commit 1e519ab

Browse files
ntkmehsbt
authored andcommitted
[rubygems/rubygems] Fix rake extension warning
rubygems/rubygems@04973e349c
1 parent 772afa0 commit 1e519ab

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/rubygems/specification_policy.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,10 +497,10 @@ def validate_rust_extensions(builder) # :nodoc:
497497

498498
def validate_rake_extensions(builder) # :nodoc:
499499
rake_extension = @specification.extensions.any? {|s| builder.builder_for(s) == Gem::Ext::RakeBuilder }
500-
rake_dependency = @specification.dependencies.any? {|d| d.name == "rake" }
500+
rake_dependency = @specification.dependencies.any? {|d| d.name == "rake" && d.type == :runtime }
501501

502502
warning <<-WARNING if rake_extension && !rake_dependency
503-
You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency in gemspec since there's no guarantee rake will be already installed.
503+
You have specified rake based extension, but rake is not added as runtime dependency. It is recommended to add rake as a runtime dependency in gemspec since there's no guarantee rake will be already installed.
504504
WARNING
505505
end
506506

test/rubygems/test_gem_specification.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2727,7 +2727,7 @@ def test_validate_rake_extension_have_rake_dependency_warning
27272727
@a1.validate
27282728
end
27292729

2730-
assert_match(/add rake as a dependency/, @ui.error)
2730+
assert_match(/add rake as a runtime dependency/, @ui.error)
27312731
end
27322732
end
27332733

@@ -2743,7 +2743,7 @@ def test_validate_rake_extension_have_rake_dependency_no_warning
27432743
@a1.validate
27442744
end
27452745

2746-
refute_match(/add rake as a dependency/, @ui.error)
2746+
refute_match(/add rake as a runtime dependency/, @ui.error)
27472747
end
27482748
end
27492749

0 commit comments

Comments
 (0)