[rubygems/rubygems] make things a bit more testable

rubygems/rubygems@29c085f5f5

Author: pjsk-stripe

lib/rubygems/s3_uri_signer.rb

@@ -147,16 +147,16 @@ def ec2_metadata_credentials_json
     require_relative "request/connection_pools"
     require "json"
     token = ec2_metadata_token
+
     iam_info = ec2_metadata_request(EC2_IAM_INFO, token)
     # Expected format: arn:aws:iam::<id>:instance-profile/<role_name>
     role_name = iam_info["InstanceProfileArn"].split("/").last
     ec2_metadata_request(EC2_IAM_SECURITY_CREDENTIALS + role_name, token)
   end
 
   def ec2_metadata_request(url, token)
-    uri = Gem::URI(url)
-    @request_pool ||= create_request_pool(uri)
-    request = Gem::Request.new(uri, Gem::Net::HTTP::Get, nil, @request_pool)
+    request = ec2_iam_request(Gem::URI(url), Gem::Net::HTTP::Get)
+
     response = request.fetch do |req|
       req.add_field "X-aws-ec2-metadata-token", token
     end
@@ -170,9 +170,8 @@ def ec2_metadata_request(url, token)
   end
 
   def ec2_metadata_token
-    uri = Gem::URI(EC2_IAM_TOKEN)
-    @request_pool ||= create_request_pool(uri)
-    request = Gem::Request.new(uri, Gem::Net::HTTP::Put, nil, @request_pool)
+    request = ec2_iam_request(Gem::URI(EC2_IAM_TOKEN), Gem::Net::HTTP::Put)
+
     response = request.fetch do |req|
       req.add_field "X-aws-ec2-metadata-token-ttl-seconds", 60
     end
@@ -185,6 +184,14 @@ def ec2_metadata_token
     end
   end
 
+  def ec2_iam_request(uri, verb)
+    @request_pool ||= {}
+    @request_pool[uri] ||= create_request_pool(uri)
+    pool = @request_pool[uri]
+
+    Gem::Request.new(uri, verb, nil, pool)
+  end
+
   def create_request_pool(uri)
     proxy_uri = Gem::Request.proxy_uri(Gem::Request.get_proxy_from_env(uri.scheme))
     certs = Gem::Request.get_cert_files