[rubygems/rubygems] Keep compatibility of past versions

rubygems/rubygems@54b67fb251

Author: hsbt

lib/bundler/yaml_serializer.rb

@@ -56,9 +56,10 @@ def load(str)
       last_hash = nil
       last_empty_key = nil
       str.split(/\r?\n/) do |line|
-        line = line.split("#", 2).first.strip if line.include?("#")
         if match = HASH_REGEX.match(line)
           indent, key, quote, val = match.captures
+          val = strip_comment(val)
+
           convert_to_backward_compatible_key!(key)
           depth = indent.size / 2
           if quote.empty? && val.empty?
@@ -73,6 +74,8 @@ def load(str)
           end
         elsif match = ARRAY_REGEX.match(line)
           _, val = match.captures
+          val = strip_comment(val)
+
           last_hash[last_empty_key] = [] unless last_hash[last_empty_key].is_a?(Array)
 
           last_hash[last_empty_key].push(val)
@@ -81,6 +84,14 @@ def load(str)
       res
     end
 
+    def strip_comment(val)
+      if val.include?("#") && !val.start_with?("#")
+        val.split("#", 2).first.strip
+      else
+        val
+      end
+    end
+
     # for settings' keys
     def convert_to_backward_compatible_key!(key)
       key << "/" if /https?:/i.match?(key) && !%r{/\Z}.match?(key)

lib/rubygems/yaml_serializer.rb

@@ -56,9 +56,10 @@ def load(str)
       last_hash = nil
       last_empty_key = nil
       str.split(/\r?\n/) do |line|
-        line = line.split("#", 2).first.strip if line.include?("#")
         if match = HASH_REGEX.match(line)
           indent, key, quote, val = match.captures
+          val = strip_comment(val)
+
           convert_to_backward_compatible_key!(key)
           depth = indent.size / 2
           if quote.empty? && val.empty?
@@ -73,6 +74,8 @@ def load(str)
           end
         elsif match = ARRAY_REGEX.match(line)
           _, val = match.captures
+          val = strip_comment(val)
+
           last_hash[last_empty_key] = [] unless last_hash[last_empty_key].is_a?(Array)
 
           last_hash[last_empty_key].push(val)
@@ -81,6 +84,14 @@ def load(str)
       res
     end
 
+    def strip_comment(val)
+      if val.include?("#") && !val.start_with?("#")
+        val.split("#", 2).first.strip
+      else
+        val
+      end
+    end
+
     # for settings' keys
     def convert_to_backward_compatible_key!(key)
       key << "/" if /https?:/i.match?(key) && !%r{/\Z}.match?(key)

spec/bundler/bundler/yaml_serializer_spec.rb

@@ -179,12 +179,12 @@
       yaml = <<~YAML
         ---
         foo: "bar"
-        buzz: # "foo"
+        buzz: "foo" # "bar"
       YAML
 
       hash = {
         "foo" => "bar",
-        "buzz" => {},
+        "buzz" => "foo",
       }
 
       expect(serializer.load(yaml)).to eq(hash)

spec/bundler/commands/config_spec.rb

@@ -439,7 +439,7 @@
     it "does not make bundler crash and ignores the configuration" do
       bundle "config list --parseable"
 
-      expect(out).to be_empty
+      expect(out).to eq("#mirror.https://rails-assets.org/=http://localhost:9292")
       expect(err).to be_empty
 
       ruby(<<~RUBY)