Attempt acquiring semaphore before releasing GVL#573
Merged
tenderworks merged 2 commits intomainfrom Apr 3, 2025
Merged
Conversation
Particularly when there are multiple threads waiting to run, there is a cost to releasing the GVL that outweighs the benefit for short system calls. This commit changes acquire_semaphore_without_gvl to attempt to acquire the semaphore while also including IPC_NOWAIT in flags, which should return immediately if the request isn't available.
|
LGTM |
Contributor
|
Just for extra context: we believe that semaphores are not contended most of the time. Which means that acquiring the lock on the semaphore is very fast. Fast enough that even if the GVL is released, no other work would actually be able to be scheduled. Since it takes time to unlock the GVL, but no other work can be scheduled, we're actually just slowing down the semaphore lock. @jhawthorn's change does a non-blocking acquire without releasing the GVL. If the lock fails, then we know the lock is contended and should take more time to lock. So in that case we'll acquire the GVL and try acquiring the lock again. |
Member
Author
|
Here's a benchmark for posterity: benchmarkrequire "semian"
require "benchmark"
require "benchmark/ips"
def fib n
(n <= 1) ? n : (fib(n-1) + fib(n-2))
end
raise "unsupported" unless Semian.sysv_semaphores_supported?
Semian.register(
:testing,
bulkhead: true,
tickets: 5,
timeout: 1,
circuit_breaker: false
)
@resource = Semian[:testing]
Benchmark.ips do |x|
x.report "1 thread" do
10_000.times do
@resource.acquire do
end
end
end
x.report "10 threads" do
10.times.map do
Thread.new do
1000.times do
@resource.acquire do
end
end
end
end.each(&:join)
end
endBefore After |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particularly when there are multiple threads waiting to run, there is a cost to releasing the GVL that outweighs the benefit for short system calls.
This commit changes acquire_semaphore_without_gvl to attempt to acquire the semaphore while also including IPC_NOWAIT in flags, which should return immediately if the request isn't available.
Discovered from looking at profiles with @rwstauner and @tenderworks