Skip to content

Commit d742b24

Browse files
Swap to regular accessor versus writer
1 parent 166a5fb commit d742b24

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

lib/shipit.rb

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,22 @@ module Shipit
6363

6464
delegate :table_name_prefix, to: :secrets
6565

66-
attr_accessor :disable_api_authentication, :timeout_exit_codes, :deployment_checks
66+
attr_accessor :disable_api_authentication, :timeout_exit_codes, :deployment_checks, :respect_bare_shipit_file
6767
attr_writer(
6868
:internal_hook_receivers,
6969
:preferred_org_emails,
7070
:task_execution_strategy,
7171
:task_logger,
72-
:respect_bare_shipit_file,
7372
)
7473

7574
def task_execution_strategy
7675
@task_execution_strategy ||= Shipit::TaskExecutionStrategy::Default
7776
end
7877

7978
self.timeout_exit_codes = [].freeze
79+
self.respect_bare_shipit_file = true
80+
81+
alias_method :respect_bare_shipit_file?, :respect_bare_shipit_file
8082

8183
def authentication_disabled?
8284
ENV['SHIPIT_DISABLE_AUTH'].present?
@@ -236,13 +238,6 @@ def task_logger
236238
@task_logger ||= Logger.new(nil)
237239
end
238240

239-
def respect_bare_shipit_file
240-
@respect_bare_shipit_file = true if @respect_bare_shipit_file.nil?
241-
!!@respect_bare_shipit_file
242-
end
243-
244-
alias_method :respect_bare_shipit_file?, :respect_bare_shipit_file
245-
246241
protected
247242

248243
def revision_file

0 commit comments

Comments
 (0)