Replace bundle install --path with bundle config set path

Author: gulkaran

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shipit-engine (0.43.0)
+    shipit-engine (0.43.1)
       active_model_serializers (~> 0.9.3)
       ansi_stream (~> 0.0.6)
       autoprefixer-rails (~> 6.4.1)

app/models/shipit/deploy_spec/bundler_discovery.rb

@@ -26,15 +26,20 @@ def discover_machine_env
       end
 
       def bundle_install
-        install_command = %(bundle install --jobs 4 --path #{bundle_path} --retry 2)
+        install_command = %(bundle install --jobs 4 --retry 2)
         install_command += " --without=#{bundler_without.join(':')}" unless bundler_without.empty?
         [
           remove_ruby_version_from_gemfile,
           (bundle_config_frozen if frozen_mode?),
+          bundle_config_path,
           install_command
         ].compact
       end
 
+      def bundle_config_path
+        "bundle config set --local path #{bundle_path}"
+      end
+
       def remove_ruby_version_from_gemfile
         # Heroku apps often specify a ruby version.
         if /darwin/i.match?(RUBY_PLATFORM)

lib/shipit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Shipit
-  VERSION = '0.43.0'
+  VERSION = '0.43.1'
 end

test/dummy/db/seeds.rb

@@ -53,7 +53,7 @@ module Shipit
               ]
             },
             "override": [
-              "bundle check --path=/tmp/bundler || bundle install --frozen --path=/tmp/bundler --retry=2 --without=default:production:development:test:staging:benchmark:debug"
+              "bundle config set path /tmp/bundler && (bundle check || bundle install --frozen --retry=2 --without=default:production:development:test:staging:benchmark:debug)"
             ]
           },
           "fetch": [

test/models/deploy_spec_test.rb

@@ -68,11 +68,13 @@ class DeploySpecTest < ActiveSupport::TestCase
       command = %(
         bundle install
         --jobs 4
-        --path #{DeploySpec.bundle_path}
         --retry 2
         --without=default:production:development:test:staging:benchmark:debug
       ).gsub(/\s+/, ' ').strip
+      config_command = "bundle config set --local path #{@spec.bundle_path}"
+
       assert_equal command, @spec.bundle_install.last
+      assert @spec.bundle_install.include?(config_command)
     end
 
     test '#bundle_install use `dependencies.bundler.without` if present to build the --without argument' do
@@ -81,7 +83,6 @@ class DeploySpecTest < ActiveSupport::TestCase
       command = %(
         bundle install
         --jobs 4
-        --path #{DeploySpec.bundle_path}
         --retry 2
         --without=some:custom:groups
       ).gsub(/\s+/, ' ').strip