Allow override in the view

Author: kovyrin

app/controllers/shipit/tasks_controller.rb

@@ -16,7 +16,6 @@ def index
     def new
       @definition = stack.find_task_definition(params[:definition_id])
       @task = stack.tasks.build(definition: @definition)
-      @task.definition.override_variables(params)
     end
 
     def show

app/models/shipit/task_definition.rb

@@ -40,14 +40,6 @@ def render_title(env)
       "This task (title: #{@title}) cannot be shown due to an incorrect variable name. Check your shipit.yml file"
     end
 
-    def override_variables(params)
-      variables.each do |var|
-        if params.key?(var.name)
-          var.override_value(params[var.name])
-        end
-      end
-    end
-
     def allow_concurrency?
       @allow_concurrency
     end

app/models/shipit/variable_definition.rb

@@ -15,14 +15,6 @@ def default_provided?
       @default_provided
     end
 
-    def override_value(value)
-      @override = value.to_s
-    end
-
-    def value
-      @override.presence || default
-    end
-
     def to_h
       {
         'name' => @name,