Upgrade Rails to 8.0 #1392
Merged
Upgrade Rails to 8.0 #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartiki975
force-pushed
the
upgrade-rails-to-8.0
branch
2 times, most recently
from
bdbe75e to
4975ab1
Compare
Contributor
Author
|
@casperisfine / @byroot As a side-effect of upgrading to rails 8.0, ruby needs to be upgraded to 3.2 and as a side effect of that Rubocop is failing. If I am not mistaken, the only way to correct the Rubocop failure is upgrading |
Contributor
|
Just remove rubocop-shopify. It never made any sense in this repo, I don't remember who sneaked it in, but it certainly isn't me. |
This comment was marked as outdated.
This comment was marked as outdated.
kartiki975
force-pushed
the
upgrade-rails-to-8.0
branch
from
c59d15a to
45529c7
Compare
kartiki975
changed the base branch from
main
to
update-rubocop-to-support-ruby-3.2
kartiki975
force-pushed
the
upgrade-rails-to-8.0
branch
from
45529c7 to
0e518ff
Compare
kartiki975
force-pushed
the
update-rubocop-to-support-ruby-3.2
branch
2 times, most recently
from
d187b84 to
8222b23
Compare
Update to required ruby version 3.2 update sqlite3 gem
kartiki975
force-pushed
the
upgrade-rails-to-8.0
branch
from
0e518ff to
b2f75f5
Compare
Contributor
Author
|
Tophat was successful |
bostonou
approved these changes
Apr 17, 2025
Contributor
Author
|
This will be merged on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade is needed for an internal Shopify ticket.
To upgrade to Rails, ruby version 3.2+ is now required. Additionally, sqlite3 gem was updated to be able to run unit tests locally.
To support, ruby version 3.2+, rubocop had to be upgraded. That has been done in the base PR.