Skip to content

Commit 010dd42

Browse files
authored
Merge pull request #1395 from Shopify/fix-branch-name-devserver
Update oauth logic to account for new admin-web url
2 parents f33b9f1 + 6091abb commit 010dd42

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
Note: For changes to the API, see https://shopify.dev/changelog?filter=api
44
## Unreleased
5+
- [#1395](https://github.com/Shopify/shopify-api-ruby/pull/1395) use correct internal admin host for 1P app development
56

67
## 14.11.0
78
- [#1386](https://github.com/Shopify/shopify-api-ruby/pull/1386) Add support for 2025-07 API version

lib/shopify_api/auth/oauth.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ def auth_base_uri(shop)
114114
return "https://#{shop}/admin" unless defined?(DevServer) && shop.include?(".my.shop.dev")
115115

116116
# For first-party apps in development only, we leverage DevServer to build the admin base URI
117-
admin_web = T.unsafe(Object.const_get("DevServer")).new("web") # rubocop:disable Sorbet/ConstantsFromStrings
117+
admin_web = T.unsafe(Object.const_get("DevServer")) # rubocop:disable Sorbet/ConstantsFromStrings
118+
.new("admin-web")
118119
admin_host = admin_web.host!(nonstandard_host_prefix: "admin")
119120
shop_name = shop.split(".").first
120121

0 commit comments

Comments
 (0)