Skip to content

Commit 0e90b6a

Browse files
committed
fix: encode OAuth URLs using URI.encode_www_form
instead of URI.escape which is deprecated.
1 parent 394377b commit 0e90b6a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/shopify_api/session.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def access_scopes=(access_scopes)
183183
end
184184

185185
def parameterize(params)
186-
URI.escape(params.collect { |k, v| "#{k}=#{v}" }.join('&'))
186+
URI.encode_www_form(params)
187187
end
188188

189189
def access_token_request(code)

test/session_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ def setup
333333
permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com", state: "My nonce")
334334
assert_equal_uri(
335335
"https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&" \
336-
"scope=&redirect_uri=http://my_redirect_uri.com&state=My%20nonce",
336+
"scope=&redirect_uri=http://my_redirect_uri.com&state=My+nonce",
337337
permission_url
338338
)
339339
end

0 commit comments

Comments
 (0)