Skip to content

Commit 2d86c15

Browse files
authored
Merge pull request #1303 from Shopify/centralize_ruby_version
Centralize Ruby Version to `.ruby-version`
2 parents a3e67f0 + e5fdb9d commit 2d86c15

File tree

14 files changed

+39
-31
lines changed

14 files changed

+39
-31
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ jobs:
1313
version:
1414
- 3.0
1515
- 3.1
16+
- 3.2
17+
- 3.3
1618
steps:
1719
- uses: actions/checkout@v2
1820
- name: Set up Ruby ${{ matrix.version }}

.rubocop.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ require:
55
- rubocop-sorbet
66

77
AllCops:
8-
TargetRubyVersion: 2.7
98
NewCops: enable
109
Exclude:
1110
- "sorbet/**/*"

.ruby-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3.0.6

Gemfile

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,22 @@ source "https://rubygems.org"
44

55
gemspec
66

7+
group :test, :development do
8+
gem "pry-byebug"
9+
end
10+
11+
group :development do
12+
gem "rake"
13+
gem "rubocop"
14+
gem "rubocop-shopify"
15+
gem "rubocop-sorbet"
16+
gem "sorbet"
17+
gem "tapioca"
18+
end
19+
720
group :test do
821
gem "minitest"
922
gem "fakefs", require: false
1023
gem "webmock"
1124
gem "mocha"
12-
gem "pry-byebug"
1325
end

Gemfile.lock

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,10 @@ GEM
4747
multi_xml (>= 0.5.2)
4848
i18n (1.14.4)
4949
concurrent-ruby (~> 1.0)
50-
json (2.6.2)
50+
json (2.7.1)
5151
jwt (2.8.1)
5252
base64
53+
language_server-protocol (3.17.0.3)
5354
method_source (1.0.0)
5455
mini_mime (1.1.5)
5556
minitest (5.15.0)
@@ -79,25 +80,26 @@ GEM
7980
rbi (0.1.8)
8081
prism (>= 0.18.0, < 0.22)
8182
sorbet-runtime (>= 0.5.9204)
82-
regexp_parser (2.5.0)
83-
rexml (3.2.5)
84-
rubocop (1.36.0)
83+
regexp_parser (2.9.0)
84+
rexml (3.2.6)
85+
rubocop (1.62.1)
8586
json (~> 2.3)
87+
language_server-protocol (>= 3.17.0)
8688
parallel (~> 1.10)
87-
parser (>= 3.1.2.1)
89+
parser (>= 3.3.0.2)
8890
rainbow (>= 2.2.2, < 4.0)
8991
regexp_parser (>= 1.8, < 3.0)
9092
rexml (>= 3.2.5, < 4.0)
91-
rubocop-ast (>= 1.20.1, < 2.0)
93+
rubocop-ast (>= 1.31.1, < 2.0)
9294
ruby-progressbar (~> 1.7)
93-
unicode-display_width (>= 1.4.0, < 3.0)
94-
rubocop-ast (1.21.0)
95-
parser (>= 3.1.1.0)
95+
unicode-display_width (>= 2.4.0, < 3.0)
96+
rubocop-ast (1.31.2)
97+
parser (>= 3.3.0.4)
9698
rubocop-shopify (2.10.1)
9799
rubocop (~> 1.35)
98100
rubocop-sorbet (0.6.11)
99101
rubocop (>= 0.90.0)
100-
ruby-progressbar (1.11.0)
102+
ruby-progressbar (1.13.0)
101103
securerandom (0.3.1)
102104
sorbet (0.5.11230)
103105
sorbet-static (= 0.5.11230)
@@ -126,7 +128,7 @@ GEM
126128
thor (1.3.0)
127129
tzinfo (2.0.6)
128130
concurrent-ruby (~> 1.0)
129-
unicode-display_width (2.3.0)
131+
unicode-display_width (2.5.0)
130132
webmock (3.14.0)
131133
addressable (>= 2.8.0)
132134
crack (>= 0.3.2)

dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: shopify-api
33
type: ruby
44

55
up:
6-
- ruby: 3.0.6
6+
- ruby
77
- bundler:
88
gemfile: Gemfile
99

lib/shopify_api/auth/session.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ def serialize
130130
sig { params(other: T.nilable(Session)).returns(T::Boolean) }
131131
def ==(other)
132132
if other
133-
(
134-
id == other.id &&
133+
134+
id == other.id &&
135135
shop == other.shop &&
136136
state == other.state &&
137137
scope == other.scope &&
@@ -140,7 +140,7 @@ def ==(other)
140140
online? == other.online? &&
141141
associated_user == other.associated_user &&
142142
shopify_session_id == other.shopify_session_id
143-
)
143+
144144
else
145145
false
146146
end

shopify_api.gemspec

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,4 @@ Gem::Specification.new do |s|
4242
s.add_runtime_dependency("securerandom")
4343
s.add_runtime_dependency("sorbet-runtime")
4444
s.add_runtime_dependency("zeitwerk", "~> 2.5")
45-
46-
s.add_development_dependency("pry-byebug")
47-
s.add_development_dependency("rake")
48-
s.add_development_dependency("rubocop")
49-
s.add_development_dependency("rubocop-shopify")
50-
s.add_development_dependency("rubocop-sorbet")
51-
s.add_development_dependency("sorbet")
52-
s.add_development_dependency("tapioca")
5345
end

test/admin_versions_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# typed: true
22
# frozen_string_literal: true
33

4-
require_relative "./test_helper"
4+
require_relative "test_helper"
55

66
module ShopifyAPITest
77
class AdminVersionsTest < Minitest::Test

test/auth_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# typed: false
22
# frozen_string_literal: true
33

4-
require_relative "./test_helper"
4+
require_relative "test_helper"
55

66
module ShopifyAPITest
77
class AuthTest < Test::Unit::TestCase

0 commit comments

Comments
 (0)