Skip to content

Commit 37cbb3e

Browse files
authored
Merge pull request #1290 from Shopify/liz/move-webhook-handle-version
Change webhook handler deprecation version
2 parents 8c351c1 + 5b87872 commit 37cbb3e

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Note: For changes to the API, see https://shopify.dev/changelog?filter=api
55
## Unreleased
66

77
- [#1288](https://github.com/Shopify/shopify-api-ruby/pull/1288) Fix FeatureDeprecatedError being raised without a message.
8+
- [1290](https://github.com/Shopify/shopify-api-ruby/pull/1290) Move deprecation of `ShopifyAPI::Webhooks::Handler#handle` to version 15.0.0
89

910
## 14.0.0
1011
- [#1274](https://github.com/Shopify/shopify-api-ruby/pull/1274) ⚠️ [Breaking] Update sorbet and rbi dependencies. Remove support for ruby 2.7. Minimum required Ruby version is 3.0

lib/shopify_api.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
require_relative "shopify_api/inflector"
1818
require_relative "shopify_api/admin_versions"
19+
require_relative "shopify_api/webhooks/handler"
1920

2021
loader = Zeitwerk::Loader.for_gem
2122
loader.inflector = ShopifyAPI::Inflector.new(__FILE__)

lib/shopify_api/webhooks/registry.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,12 @@ def process(request)
198198
body: request.parsed_body, api_version: request.api_version, webhook_id: request.webhook_id))
199199
else
200200
handler.handle(topic: request.topic, shop: request.shop, body: request.parsed_body)
201-
ShopifyAPI::Logger.deprecated(
202-
"DEPRECATED: Use ShopifyAPI::Webhooks::WebhookHandler#handle \
203-
instead of ShopifyAPI::Webhooks::Handler#handle.
204-
https://github.com/Shopify/shopify-api-ruby/blob/main/docs/usage/webhooks.md#create-a-webhook-handler",
205-
"14.0.0",
206-
)
201+
warning = <<~WARNING
202+
DEPRECATED: Use ShopifyAPI::Webhooks::WebhookHandler#handle instead of
203+
ShopifyAPI::Webhooks::Handler#handle.
204+
https://github.com/Shopify/shopify-api-ruby/blob/main/docs/usage/webhooks.md#create-a-webhook-handler
205+
WARNING
206+
ShopifyAPI::Logger.deprecated(warning, "15.0.0")
207207
end
208208
end
209209

0 commit comments

Comments
 (0)