Raise missing jwt token error in session_id_from_shopify_id_token

Author: zzooeeyy

lib/shopify_api/utils/session_utils.rb

@@ -43,11 +43,13 @@ def current_session_id(auth_header, cookies, online)
 
         sig do
           params(
-            id_token: String,
+            id_token: T.nilable(String),
             online: T::Boolean,
           ).returns(String)
         end
         def session_id_from_shopify_id_token(id_token:, online:)
+          raise Errors::MissingJwtTokenError, "Missing Shopify ID Token" unless id_token
+
           payload = Auth::JwtPayload.new(id_token)
           shop = payload.shop
 

test/utils/session_utils_test.rb

@@ -49,6 +49,14 @@ def test_session_id_from_shopify_id_token_raises_invalid_jwt_errors
         end
       end
 
+      def test_session_id_from_shopify_id_token_raises_missing_jwt_token_error
+        error = assert_raises(ShopifyAPI::Errors::MissingJwtTokenError) do
+          ShopifyAPI::Utils::SessionUtils.session_id_from_shopify_id_token(id_token: nil, online: true)
+        end
+
+        assert_equal("Missing Shopify ID Token", error.message)
+      end
+
       def test_non_embedded_app_current_session_id_raises_cookie_not_found_error
         ShopifyAPI::Context.stubs(:embedded?).returns(false)