Make sub and sid jwt claims optional #1369
Conversation
BaggioGiacomo
force-pushed
the
make-jwt-sid-and-sub-claims-optional
branch
from
fc02a05 to
96be21d
Compare
| sig { returns(Integer) } | ||
| def shopify_user_id | ||
| @sub.to_i | ||
| end |
There was a problem hiding this comment.
How can this work?
If the sub is gid://shopify/Customer/123456789, shouldn't this method return 123456789?
gid://shopify/Customer/123456789.to_i returns 0
@lizkenyon I think this is the answer to your question here: https://github.com/Shopify/shopify-api-ruby/pull/1346/files#r1831667330
BaggioGiacomo
force-pushed
the
make-jwt-sid-and-sub-claims-optional
branch
from
96be21d to
300e713
Compare
The generated session token on the checkout ui extensions doesn't contain: - The `sid` claim - The `sub` claim if the customer is not logged in Making them mandatory causes an `Expected type String, got type NilClass` error
BaggioGiacomo
force-pushed
the
make-jwt-sid-and-sub-claims-optional
branch
from
300e713 to
4bc8538
Compare
lizkenyon
left a comment
lizkenyon
left a comment
There was a problem hiding this comment.
A few comments!
One question I have is how are you (or how are you planning to) currently validating your session token in your app? ie. Are you using a controller concern from shopify_app?
Yes, I've an |
…from the admin and the sub claim is an user id
lizkenyon
left a comment
lizkenyon
left a comment
There was a problem hiding this comment.
Thank you for your contribution! ⭐
2 participants
Description
The generated session token on the checkout ui extensions doesn't contain:
sidclaimsubclaim if the customer is not logged inHaving them mandatory causes an
Expected type String, got type NilClasserrorHow has this been tested?
After adding the patch, I've made my app use my local version of the
shopify-apigem:After that, I've tested my app and session works correctly
I've finally tested the checkout ui extension and no errors is thrown now. Also I'm now able to get the logged in customer by decoding the jwt
Checklist: