Merge pull request #1960 from Shopify/remove-jwt-middleware

[Breaking] Removes ShopifyApp::JWTMiddleware

Author: lizkenyon

CHANGELOG.md

@@ -1,5 +1,6 @@
 Unreleased
 ----------
+- ⚠️ [Breaking] Removes `ShopifyApp::JWTMiddleware` and `ShopifyApp::JWT` See [Upgrading](/docs/Upgrading.md) for more migration. [1960](https://github.com/Shopify/shopify_app/pull/1960)
 - ⚠️ [Breaking] Removed deprecated `CallbackController` methods. `perform_after_authenticate_job`, `install_webhooks`, and `perform_post_authenticate_jobs` have been removed. [#1961](https://github.com/Shopify/shopify_app/pull/1961)
 - ⚠️ [Breaking] Bumps minimum supported Ruby version to 3.1 [#1959](https://github.com/Shopify/shopify_app/pull/1959)
 - Adds a `script_tag_manager` that will automatically create script tags when the app is installed. [1948](https://github.com/Shopify/shopify_app/pull/1948)

Gemfile.lock

@@ -3,7 +3,6 @@ PATH
   specs:
     shopify_app (22.5.2)
       addressable (~> 2.7)
-      jwt (>= 2.2.3)
       rails (> 5.2.1)
       redirect_safely (~> 1.0)
       shopify_api (>= 14.7.0, < 15.0)
@@ -258,6 +257,7 @@ PLATFORMS
 
 DEPENDENCIES
   byebug
+  jwt (>= 2.2.3)
   minitest
   mocha
   pry

lib/shopify_app.rb

@@ -69,14 +69,11 @@ def self.use_webpacker?
   # managers
   require "shopify_app/managers/webhooks_manager"
   require "shopify_app/managers/script_tags_manager"
-  # middleware
-  require "shopify_app/middleware/jwt_middleware"
 
   # session
   require "shopify_app/session/in_memory_session_store"
   require "shopify_app/session/in_memory_shop_session_store"
   require "shopify_app/session/in_memory_user_session_store"
-  require "shopify_app/session/jwt"
   require "shopify_app/session/null_user_session_store"
   require "shopify_app/session/session_repository"
   require "shopify_app/session/session_storage"

lib/shopify_app/engine.rb

@@ -16,10 +16,6 @@ class Engine < Rails::Engine
     engine_name "shopify_app"
     isolate_namespace ShopifyApp
 
-    initializer "shopify_app.middleware" do |app|
-      app.config.middleware.insert_after(::Rack::Runtime, ShopifyApp::JWTMiddleware)
-    end
-
     initializer "shopify_app.assets.precompile" do |app|
       app.config.assets.precompile += [
         "shopify_app/redirect.js",

lib/shopify_app/middleware/jwt_middleware.rb

@@ -18,10 +18,8 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency("rails", "> 5.2.1")
   s.add_runtime_dependency("redirect_safely", "~> 1.0")
   s.add_runtime_dependency("shopify_api", ">= 14.7.0", "< 15.0")
-  # Deprecated: move to development dependencies when releasing v23
-  s.add_runtime_dependency("jwt", ">= 2.2.3")
-
   s.add_development_dependency("byebug")
+  s.add_development_dependency("jwt", ">= 2.2.3")
   s.add_development_dependency("minitest")
   s.add_development_dependency("mocha")
   s.add_development_dependency("pry")