Skip to content

Commit daaf498

Browse files
authored
Merge pull request #2020 from Shopify/jk-update-rails-loading
Fix loading issues with modern rails versions
2 parents 956f892 + 9873d15 commit daaf498

File tree

79 files changed

+356
-213
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+356
-213
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
name: Ruby ${{ matrix.version }}
1313
strategy:
1414
matrix:
15-
version: ['3.1', '3.2', '3.3']
15+
version: ['3.2', '3.3', '3.4']
1616

1717
steps:
1818
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
Unreleased
22
----------
3+
- ⚠️ [Breaking] Bumps minimum supported Rails version to 7.1 & Ruby version to 3.2; moves jobs from `lib` to `app` to fix loading issues with modern rails versions. [#2020](https://github.com/Shopify/shopify_app/pull/2020)
4+
- ActiveJob classes moved from `lib/shopify_app/jobs/` to `app/jobs/shopify_app/` to follow Rails conventions and fix timing issues with ActiveJob initialization
5+
- Jobs are now autoloaded by Rails instead of explicitly required during gem initialization
6+
- **For most apps**: No changes needed. Jobs are internal to the gem and will be autoloaded correctly
7+
- **If your app has custom ActiveJob serializers**: See [Upgrading guide](/docs/Upgrading.md#v2300-minimum-ruby-32-and-rails-71-required-jobs-moved-to-appjobs) for migration steps
8+
- Additional dependency updates: sqlite3 (1.x → 2.x), added `csv` and `mutex_m` development dependencies for Ruby 3.4+ compatibility
39
- ⚠️ [Breaking] Removes `ShopifyApp::JWTMiddleware` and `ShopifyApp::JWT` See [Upgrading](/docs/Upgrading.md) for more migration. [1960](https://github.com/Shopify/shopify_app/pull/1960)
410
- ⚠️ [Breaking] Removed deprecated `CallbackController` methods. `perform_after_authenticate_job`, `install_webhooks`, and `perform_post_authenticate_jobs` have been removed. [#1961](https://github.com/Shopify/shopify_app/pull/1961)
511
- ⚠️ [Breaking] Bumps minimum supported Ruby version to 3.1 [#1959](https://github.com/Shopify/shopify_app/pull/1959)

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ source "https://rubygems.org"
66
gemspec
77

88
gem "rails-controller-testing", group: :test
9-
gem "rails", "< 7" # temporary: https://github.com/Shopify/shopify_app/pull/1561
9+
gem "rails", "~> 7.1.0"
1010

1111
group :rubocop do
1212
gem "rubocop-shopify", require: false

0 commit comments

Comments
 (0)