Move definition of makeRBSString to shared rbs_common.cc

Author: KaanOzkan

rbs/SignatureTranslator.cc

@@ -9,14 +9,6 @@ using namespace std;
 
 namespace sorbet::rbs {
 
-namespace {
-
-rbs_string_t makeRBSString(const string &str) {
-    return rbs_string_new(str.data(), str.data() + str.size());
-}
-
-} // namespace
-
 unique_ptr<parser::Node>
 SignatureTranslator::translateAssertionType(vector<pair<core::LocOffsets, core::NameRef>> typeParams,
                                             const rbs::RBSDeclaration &assertion) {

rbs/rbs_common.cc

@@ -34,4 +34,8 @@ core::LocOffsets RBSDeclaration::typeLocFromRange(const rbs_range_t &range) cons
     }
     return comments.front().typeLoc;
 }
+rbs_string_t makeRBSString(const std::string_view str) {
+    return rbs_string_new(str.data(), str.data() + str.size());
+}
+
 } // namespace sorbet::rbs