Merge pull request #90 from Shopify/at-fix-bump-bug

Avoid changing the sigils of files not bumped

Author: Morriar

lib/spoom/cli/bump.rb

@@ -102,6 +102,7 @@ def bump(directory = ".")
           path = File.expand_path(err.file)
           next unless path.start_with?(directory)
           next unless File.file?(path)
+          next unless files_to_bump.include?(path)
           path
         end.compact.uniq
 

test/spoom/cli/bump_test.rb

@@ -315,6 +315,36 @@ def test_bump_dry_does_nothing_with_no_bumpable_file
         assert_equal("false", Sorbet::Sigils.file_strictness("#{@project.path}/file2.rb"))
       end
 
+      def test_bump_dry_does_not_revert_files_not_bumped
+        @project.write("file1.rb", <<~RB)
+          # typed: false
+          class A
+            def foo(a, b); end
+          end
+        RB
+        @project.write("file2.rbi", <<~RB)
+          # typed: true
+          class A
+            def foo(a, b, c); end
+          end
+        RB
+
+        out, err, status = @project.bundle_exec("spoom bump --no-color --from false --to true --dry")
+        assert_empty(err)
+        assert_equal(<<~OUT, out)
+          Checking files...
+
+          Can bump `1` file from `false` to `true`:
+           + file1.rb
+
+          Run `spoom bump --from false --to true` locally then `commit the changes` and `push them`
+        OUT
+        refute(status)
+
+        assert_equal("false", Sorbet::Sigils.file_strictness("#{@project.path}/file1.rb"))
+        assert_equal("true", Sorbet::Sigils.file_strictness("#{@project.path}/file2.rbi"))
+      end
+
       def test_bump_only_specified_files
         @project.write("file1.rb", "# typed: false")
         @project.write("file2.rb", "# typed: false")