Update translation of RBS abstract methods to conditionally call super

Author: jesse-shopify

lib/spoom/sorbet/translate/sorbet_sigs_to_rbs_comments.rb

@@ -59,6 +59,8 @@ def visit_singleton_class_node(node)
           visit_scope(node) { super }
         end
 
+        ABSTRACT_METHOD_BODY = "defined?(super) ? super : raise(NotImplementedError, \"Abstract method called\")"
+
         # @override
         #: (Prism::DefNode) -> void
         def visit_def_node(node)
@@ -87,9 +89,9 @@ def visit_def_node(node)
               node.location.end_offset - 1,
               if node.name.end_with?("=")
                 indent = " " * node.location.start_column
-                "\n#{indent}  raise NotImplementedError, \"Abstract method called\"\n#{indent}end"
+                "\n#{indent}  #{ABSTRACT_METHOD_BODY}\n#{indent}end"
               else
-                " = raise NotImplementedError, \"Abstract method called\""
+                " = #{ABSTRACT_METHOD_BODY}"
               end,
             )
           end

test/spoom/cli/srb/sigs_test.rb

@@ -342,7 +342,7 @@ def foo; end
             class A
               # @abstract
               #: -> void
-              def foo = raise NotImplementedError, "Abstract method called"
+              def foo = defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
             end
           RB
         end

test/spoom/sorbet/translate/sorbet_sigs_to_rbs_comments_test.rb

@@ -102,28 +102,28 @@ def bar=(x)
             class Foo
               # @abstract
               #: -> void
-              def foo = raise NotImplementedError, "Abstract method called"
+              def foo = defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
 
               class Bar
                 # @abstract
                 #: -> void
-                def bar = raise NotImplementedError, "Abstract method called"
+                def bar = defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
               end
 
               # @abstract
               #: (Integer x) -> void
-              def baz(x) = raise NotImplementedError, "Abstract method called"
+              def baz(x) = defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
 
               # @abstract
               #: (Integer x) -> void
               def foo=(x)
-                raise NotImplementedError, "Abstract method called"
+                defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
               end
 
               # @abstract
               #: (Integer x) -> void
               def bar=(x)
-                raise NotImplementedError, "Abstract method called"
+                defined?(super) ? super : raise(NotImplementedError, "Abstract method called")
               end
             end
           RBS