Merge pull request #2497 from caleb/master

Make ActiveRecord delete/destroy_by argument a rest parameters

Author: paracycle

lib/tapioca/dsl/compilers/active_record_relations.rb

@@ -945,7 +945,7 @@ def create_common_methods
               common_relation_methods_module.create_method(
                 method_name.to_s,
                 parameters: [
-                  create_param("args", type: "T.untyped"),
+                  create_rest_param("args", type: "T.untyped"),
                 ],
                 return_type: method_name == :delete_by ? "Integer" : "T::Array[#{constant_name}]",
               )

spec/tapioca/dsl/compilers/active_record_relations_spec.rb

@@ -139,7 +139,7 @@ def delete(*records); end
                     def delete_all; end
 
                     sig { params(args: T.untyped).returns(Integer) }
-                    def delete_by(args); end
+                    def delete_by(*args); end
 
                     sig { params(records: T.any(::Post, Integer, String, T::Enumerable[T.any(::Post, Integer, String, T::Enumerable[::Post])])).returns(T::Array[::Post]) }
                     def destroy(*records); end
@@ -151,7 +151,7 @@ def destroy_all; end
                     def destroy_all; end
 
                     sig { params(args: T.untyped).returns(T::Array[::Post]) }
-                    def destroy_by(args); end
+                    def destroy_by(*args); end
 
                     sig { params(conditions: T.untyped).returns(T::Boolean) }
                     def exists?(conditions = :none); end
@@ -846,7 +846,7 @@ def delete(*records); end
                     def delete_all; end
 
                     sig { params(args: T.untyped).returns(Integer) }
-                    def delete_by(args); end
+                    def delete_by(*args); end
 
                     sig { params(records: T.any(::Post, Integer, String, T::Enumerable[T.any(::Post, Integer, String, T::Enumerable[::Post])])).returns(T::Array[::Post]) }
                     def destroy(*records); end
@@ -858,7 +858,7 @@ def destroy_all; end
                     def destroy_all; end
 
                     sig { params(args: T.untyped).returns(T::Array[::Post]) }
-                    def destroy_by(args); end
+                    def destroy_by(*args); end
 
                     sig { params(conditions: T.untyped).returns(T::Boolean) }
                     def exists?(conditions = :none); end