Skip to content

Commit f5abd4a

Browse files
authored
Merge pull request #321 from Shopify/require-double-quote
Complie requires file with double quotes instead of single quotes
2 parents e680cc6 + 68e1a54 commit f5abd4a

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

lib/tapioca/compilers/requires_compiler.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def compile
2222
name_in_project?(files, req)
2323
end
2424
end.sort.uniq.map do |name|
25-
"require '#{name}'\n"
25+
"require \"#{name}\"\n"
2626
end.join
2727
end
2828

spec/tapioca/cli_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,11 +290,11 @@ module Foo::Undef2; end
290290
291291
# typed: false
292292
293-
require 'active_support/all'
294-
require 'baz'
295-
require 'foo/secret'
296-
require 'foo/will_fail'
297-
require 'smart_properties'
293+
require "active_support/all"
294+
require "baz"
295+
require "foo/secret"
296+
require "foo/will_fail"
297+
require "smart_properties"
298298
CONTENTS
299299
end
300300

@@ -321,7 +321,7 @@ module Foo::Undef2; end
321321
322322
# typed: false
323323
324-
require 'foo/secret'
324+
require "foo/secret"
325325
CONTENTS
326326
end
327327
end

spec/tapioca/compilers/requires_compiler_spec.rb

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,44 +12,44 @@ class Tapioca::Compilers::RequiresCompilerSpec < Minitest::HooksSpec
1212
it("it extracts the requires from a simple project") do
1313
compiler = Tapioca::Compilers::RequiresCompiler.new('spec/support/require/simple/sorbet/config')
1414
assert_equal(<<~REQ, compiler.compile)
15-
require 'a'
16-
require 'b'
17-
require 'c'
18-
require 'd'
19-
require 'e'
20-
require 'f'
21-
require 'g'
22-
require 'h'
23-
require 'i'
24-
require 'j'
15+
require "a"
16+
require "b"
17+
require "c"
18+
require "d"
19+
require "e"
20+
require "f"
21+
require "g"
22+
require "h"
23+
require "i"
24+
require "j"
2525
REQ
2626
end
2727

2828
it("it extracts the requires from all the files listed in the sorbet config") do
2929
compiler = Tapioca::Compilers::RequiresCompiler.new('spec/support/require/multi/sorbet/config')
3030
assert_equal(<<~REQ, compiler.compile)
31-
require 'a'
32-
require 'b'
33-
require 'c'
34-
require 'd'
31+
require "a"
32+
require "b"
33+
require "c"
34+
require "d"
3535
REQ
3636
end
3737

3838
it("it ignores files ignored in the sorbet config") do
3939
compiler = Tapioca::Compilers::RequiresCompiler.new('spec/support/require/sorbet_ignore/sorbet/config')
4040
assert_equal(<<~REQ, compiler.compile)
41-
require 'c'
42-
require 'd'
41+
require "c"
42+
require "d"
4343
REQ
4444
end
4545

4646
it("it ignores files located in the project") do
4747
compiler = Tapioca::Compilers::RequiresCompiler.new('spec/support/require/project_ignore/sorbet/config')
4848
assert_equal(<<~REQ, compiler.compile)
49-
require 'liba'
50-
require 'libb'
51-
require 'libc'
52-
require 'libd'
49+
require "liba"
50+
require "libb"
51+
require "libc"
52+
require "libd"
5353
REQ
5454
end
5555
end

0 commit comments

Comments
 (0)