Updated the undefined-object theme check to skip over inline-snippets

Author: shoplando

.changeset/sweet-steaks-greet.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme-check-common': minor
+---
+
+Updated the `Undefined-object` theme check to skip over the new `snippet` tags

packages/theme-check-common/src/checks/undefined-object/index.spec.ts

@@ -459,4 +459,18 @@ describe('Module: UndefinedObject', () => {
     assert(offenses.length == 0);
     expect(offenses).to.be.empty;
   });
+
+  it('should not report an offense for inline snippet names in snippet and render tags', async () => {
+    const sourceCode = `
+      {% snippet my_inline_snippet %}
+        {% echo 'hello' %}
+      {% endsnippet %}
+
+      {% render my_inline_snippet %}
+    `;
+
+    const offenses = await runLiquidCheck(UndefinedObject, sourceCode);
+
+    expect(offenses).toHaveLength(0);
+  });
 });

packages/theme-check-common/src/checks/undefined-object/index.ts

@@ -142,6 +142,10 @@ export const UndefinedObject: LiquidCheckDefinition = {
         const parent = last(ancestors);
         if (isLiquidTag(parent) && isLiquidTagCapture(parent)) return;
 
+        if (parent?.type === NodeTypes.RenderMarkup && parent.snippet === node) return;
+
+        if (isLiquidTag(parent) && parent.name === 'snippet' && parent.markup === node) return;
+
         variables.push(node);
       },